Skip to content

fix(ci): narrow vdev path filter to Cargo.toml in changes.yml#25929

Open
thomasqueirozb wants to merge 2 commits into
masterfrom
fix/ci-vdev-path-filter
Open

fix(ci): narrow vdev path filter to Cargo.toml in changes.yml#25929
thomasqueirozb wants to merge 2 commits into
masterfrom
fix/ci-vdev-path-filter

Conversation

@thomasqueirozb

@thomasqueirozb thomasqueirozb commented Jul 22, 2026

Copy link
Copy Markdown
Member

Summary

The vdev/** glob in changes.yml path filters was too broad now that we're installing released vdev versions. Narrowed to vdev/Cargo.toml to only trigger when vdev's dependency manifest changes. CI effectively only updates the running vdev version once version = is bumped in vdev/Cargo.toml.

Vector configuration

NA

How did you test this PR?

NA

Change Type

  • Bug fix
  • Non-functional (chore, refactoring, docs)
  • New feature
  • Dependencies
  • Performance

Is this a breaking change?

  • Yes
  • No

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the no-changelog label to this PR.

References

NA

@thomasqueirozb thomasqueirozb added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jul 22, 2026
@github-actions github-actions Bot added the domain: ci Anything related to Vector's CI environment label Jul 22, 2026
@thomasqueirozb
thomasqueirozb marked this pull request as ready for review July 22, 2026 21:06
@thomasqueirozb
thomasqueirozb requested a review from a team as a code owner July 22, 2026 21:06
@datadog-vectordotdev

datadog-vectordotdev Bot commented Jul 22, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 14acbe0 | Docs | Give us feedback!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 41c4c59518

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread .github/workflows/changes.yml Outdated
@pront

pront commented Jul 23, 2026

Copy link
Copy Markdown
Member

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 14acbe0334

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: ci Anything related to Vector's CI environment no-changelog Changes in this PR do not need user-facing explanations in the release changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants