fix(vitest): loosen onConsoleLog return type - #5337
Merged
sheremet-va merged 2 commits intoMar 5, 2024
Merged
Conversation
✅ Deploy Preview for fastidious-cascaron-4ded94 canceled.
|
hi-ogawa
marked this pull request as ready for review
March 5, 2024 00:55
AriPerkkio
approved these changes
Mar 5, 2024
sheremet-va
approved these changes
Mar 5, 2024
6 tasks
1 task
1 task
This was referenced May 21, 2024
This was referenced Jul 8, 2024
Merged
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
false | undefinedorboolean | undefined#5317I think this is a minor paper cut and loosening it makes sense to allow something like:
Currently users need to rewrite it into a following, which seems unnecessary restriction. Also it seems some eslint rule doesn't like this form.
I don't know about
voidvsundefined, so I keptvoidhere.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.