Skip to content

feat: support for guzzle 8 - #427

Open
VincentLanglet wants to merge 2 commits into
workos:mainfrom
VincentLanglet:guzzle8
Open

feat: support for guzzle 8#427
VincentLanglet wants to merge 2 commits into
workos:mainfrom
VincentLanglet:guzzle8

Conversation

@VincentLanglet

@VincentLanglet VincentLanglet commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Description

Documentation

Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.

[ ] Yes

If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.

Ref:

@VincentLanglet
VincentLanglet requested review from a team as code owners July 29, 2026 09:23
@VincentLanglet VincentLanglet changed the title Add support for guzzle 8 feat: support for guzzle 8 Jul 29, 2026
@VincentLanglet
VincentLanglet marked this pull request as draft July 29, 2026 09:25
Comment thread composer.json
@greptile-apps

greptile-apps Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR extends the SDK’s HTTP transport compatibility to Guzzle 8.

  • Allows Composer to resolve either Guzzle 7 or Guzzle 8.
  • Uses the Guzzle 8 response and timeout exception types while retaining guarded compatibility with Guzzle 7 methods.
  • Preserves API-error mapping, retry handling, and transport-timeout classification across supported versions.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously reported unconditional calls to Guzzle exception methods are now replaced with Guzzle 8 exception types and guarded Guzzle 7 compatibility paths.

Important Files Changed

Filename Overview
composer.json Expands the supported Guzzle dependency constraint from version 7 to versions 7 or 8.
lib/HttpClient.php Reworks response and timeout exception inspection to avoid calling methods removed in Guzzle 8 while retaining Guzzle 7 compatibility.

Reviews (2): Last reviewed commit: "Add BC layer" | Re-trigger Greptile

@VincentLanglet
VincentLanglet marked this pull request as ready for review July 29, 2026 09:40
@VincentLanglet

Copy link
Copy Markdown
Contributor Author

I saw you opened/merged recently @gjtorikian ; could you approve the workflow ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant