Fix CI: build core before typecheck, fix null-narrowing in BlockEditor - #2
Merged
Merged
Conversation
CI ran typecheck before build, so @xproeditor/vue and @xproeditor/react couldn't resolve @xproeditor/core (its package.json points at ./dist, which didn't exist yet) — this cascaded into dozens of "cannot find module" and implicit-any errors. Reorder the workflow to build first. Also fixes two genuine strict-null narrowing gaps in both BlockEditor implementations: `dropTarget?.id === x ? dropTarget.position : ...` and the equivalent for `iconPickerRequest` don't let TypeScript narrow the optional value across the ternary; rewritten as explicit `&&` checks. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI ran typecheck before build, so @xproeditor/vue and @xproeditor/react couldn't resolve @xproeditor/core (its package.json points at ./dist, which didn't exist yet) — this cascaded into dozens of "cannot find module" and implicit-any errors. Reorder the workflow to build first.
Also fixes two genuine strict-null narrowing gaps in both BlockEditor implementations:
dropTarget?.id === x ? dropTarget.position : ...and the equivalent foriconPickerRequestdon't let TypeScript narrow the optional value across the ternary; rewritten as explicit&&checks.