Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #167 +/- ##
=============================================
+ Coverage 99.79% 100.00% +0.20%
+ Complexity 172 171 -1
=============================================
Files 7 7
Lines 478 476 -2
=============================================
- Hits 477 476 -1
+ Misses 1 0 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR removes a redundant special-case branch in StringHelper::truncateWordsByLength() that never altered the returned value due to the existing $length <= $markerLength guard, simplifying the word-boundary truncation path without changing behavior.
Changes:
- Simplified the “last space within snippet” return path in
StringHelper::truncateWordsByLength()by removing dead code. - Documented the internal cleanup in
CHANGELOG.mdunder the upcoming release.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/StringHelper.php | Removes an unreachable/redundant conditional branch and returns the same value via the general concatenation path. |
| CHANGELOG.md | Adds an entry noting the dead-code removal enhancement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Tigrov
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The branch existed to handle
$cut === '', returningmb_substr($trimMarker, 0, $length, $encoding). But$length > $markerLengthis already guaranteed by the earlier check on line 376, so thatmb_substrcall always returns$trimMarkerin full — the same value the general branch produces via$cut . $trimMarkerwhen$cutis empty. So thespecial-case branch never changed the output; it was redundant dead code duplicating the general case.