Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Revert "Cat people have feline screams now and custom emote (#11642)" - #11736

Merged
alexkar598 merged 1 commit into
yogstation13:masterfrom
Bibby0110:revert-11642-Cat-Emotes
Jul 8, 2021
Merged

Revert "Cat people have feline screams now and custom emote (#11642)"#11736
alexkar598 merged 1 commit into
yogstation13:masterfrom
Bibby0110:revert-11642-Cat-Emotes

Conversation

@Bibby0110

Copy link
Copy Markdown
Contributor

image
Fetish content?

🆑
rscdel: Removed cat meows and feline screams
/:cl:

@Bibby0110
Bibby0110 requested a review from a team as a code owner July 8, 2021 21:32
@Yogbot-13 Yogbot-13 added Revert / Deletion Altoids is probably mad about this Sound This PR changes audio files labels Jul 8, 2021

@alexkar598 alexkar598 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is good

@Bibby0110

Copy link
Copy Markdown
Contributor Author

Code is good

so are you

@Mqiib

Mqiib commented Jul 8, 2021

Copy link
Copy Markdown
Contributor

I dunno I think it's kinda fun. Why remove it?

@alexkar598

Copy link
Copy Markdown
Member
  1. It sounds horrible
  2. Its too loud
  3. Its cat noises for humans with a cat tail and a cat ear
  4. Source of sound is unclear and possibly a license violation

@boba247

boba247 commented Jul 8, 2021

Copy link
Copy Markdown

A cool-down should be added if is kept. I think it should just be reverted.

@nesisknesis nesisknesis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though I was the one to approve this, I regret it and will accept any due criticism for going back on it

I believe this infringes on a level of integrity we should uphold on the more dubious features in our codebase

thank you and good night

@Bibby0110 Bibby0110 closed this Jul 8, 2021
@nesisknesis nesisknesis reopened this Jul 8, 2021
@Bibby0110 Bibby0110 closed this Jul 8, 2021
@nesisknesis nesisknesis reopened this Jul 8, 2021
@Moja10

Moja10 commented Jul 8, 2021

Copy link
Copy Markdown
Contributor

This is an actual PR you monkeys leave it open.

@Bibby0110 Bibby0110 closed this Jul 8, 2021
@Bibby0110 Bibby0110 reopened this Jul 8, 2021
@Bibby0110

Copy link
Copy Markdown
Contributor Author

mis click

@nesisknesis

Copy link
Copy Markdown
Contributor

mis click

totally understandable

@alexkar598

alexkar598 commented Jul 8, 2021

Copy link
Copy Markdown
Member

This is currently an exploit that can cause lag via spamming emotes sounds on lower end computers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Revert / Deletion Altoids is probably mad about this Sound This PR changes audio files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants