Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Adds Custom Mentor role, can Add Wiki and Stuff now - #12014

Merged
JamieD1 merged 12 commits into
masterfrom
Unopresses-Wiki
Aug 21, 2021
Merged

Adds Custom Mentor role, can Add Wiki and Stuff now#12014
JamieD1 merged 12 commits into
masterfrom
Unopresses-Wiki

Conversation

@JamieD1

@JamieD1 JamieD1 commented Aug 12, 2021

Copy link
Copy Markdown
Contributor

Adds Custom Mentor role, can Add Wiki and Stuff now

@alexkar598 alexkar598 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update SQL schema

@JamieD1
JamieD1 requested a review from a team August 12, 2021 20:33
@github-actions github-actions Bot added Admin This PR affects administrators SQL This PR has SQL code within, likely database related labels Aug 12, 2021
@alexkar598

Copy link
Copy Markdown
Member

For the record, storing the rank as a string across all rows is a stupid idea

@adamsong

Copy link
Copy Markdown
Contributor

How would you recommend storing it?

@alexkar598

Copy link
Copy Markdown
Member

As an id which points to a rank

@adamsong

adamsong commented Aug 13, 2021

Copy link
Copy Markdown
Contributor

Admin ranks use a string

@alexkar598

Copy link
Copy Markdown
Member

Whoever came up with that idea doesn't know how a relational database works

@Bibby0110

Copy link
Copy Markdown
Contributor

Whoever came up with that idea doesn't know how a relational database works

our codebase in a nutshell

@JamieD1
JamieD1 requested a review from a team as a code owner August 14, 2021 13:37
Comment thread SQL/database_changelog.txt
@N3D6

N3D6 commented Aug 17, 2021

Copy link
Copy Markdown
Contributor

Maybe needs a bug report but right now rementoring after dementoring makes your role show up as [] when you talk in OOC

@JamieD1
JamieD1 merged commit 0b601e5 into master Aug 21, 2021
@JamieD1
JamieD1 deleted the Unopresses-Wiki branch August 21, 2021 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Admin This PR affects administrators SQL This PR has SQL code within, likely database related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants