Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Revert "Adds a racial language for every xeno who doesn't have one" - #12160

Closed
tattax wants to merge 1 commit into
yogstation13:masterfrom
tattax:revert-12082-languages-for-all
Closed

Revert "Adds a racial language for every xeno who doesn't have one"#12160
tattax wants to merge 1 commit into
yogstation13:masterfrom
tattax:revert-12082-languages-for-all

Conversation

@tattax

@tattax tattax commented Aug 26, 2021

Copy link
Copy Markdown
Contributor

Github documenting your Pull Request

Reverts #12082 cause as again stated no race needs their own language as it creates a barrier beetween players and really pushes the ''i'll ignore you cause you're not my race / don't speak my tongue'' type of mentality players tend to have. also PR had a 1:2 like to dislike ratio and got merged anyways.

Changelog

🆑
rscdel: removed languages from plasmaman, moth and etheral
imagedel: deleted language stuff
/:cl:

@tattax
tattax requested a review from a team as a code owner August 26, 2021 12:12
@github-actions github-actions Bot added the Sprites This PR has spriting changes label Aug 26, 2021
@nesisknesis

Copy link
Copy Markdown
Contributor

Added the documentation template for you, you'll need to fill the changelog out. Also I think you need a stronger argument if you want this merged since you're directly contesting the person who merged it's decision to merge the last pr.

@JamieD1 JamieD1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This literally just adds options for races that dont have a "sheltered" language to have one.

Humans have japanese
Lizards have draconic

So your argument is basically pointless as this just adds the unique sheltered languages for different races.

Do you expect a pod person to learn fecking japanese?

EDIT: Nevermind didn't read it properly. Will confer with a few others.

@JamieD1

JamieD1 commented Sep 11, 2021

Copy link
Copy Markdown
Contributor

This has been merged a while and the " ''i'll ignore you cause you're not my race / don't speak my tongue'' type of mentality players tend to have." behaviour has not come about as of yet.

If this comes up in the future we can look back into this. For now it adds some nice additions to playing different species.

@JamieD1 JamieD1 closed this Sep 11, 2021
@Yogbot-13 Yogbot-13 added DME Edit This PR affects the yogstation.DME file Revert / Deletion Altoids is probably mad about this labels Sep 11, 2021
@tattax
tattax deleted the revert-12082-languages-for-all branch January 10, 2023 08:55
@tattax
tattax restored the revert-12082-languages-for-all branch January 10, 2023 08:55
@tattax
tattax deleted the revert-12082-languages-for-all branch January 10, 2023 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

DME Edit This PR affects the yogstation.DME file Revert / Deletion Altoids is probably mad about this Sprites This PR has spriting changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants