This repository was archived by the owner on May 22, 2025. It is now read-only.
Replacing a borg's bulb actually fixes it - #13508
Merged
Merged
Conversation
Replacing a borg's bulb actually makes its lamp functional
Contributor
|
Does charging set the lamps cooldown to 0? if so, then this should regenerate the lamp too. |
Contributor
Author
|
I cannot find anything in rechargestation.dm or robot.dm about changing a borg's lamp_cooldown or regenerating a headlamp. The problem that this PR fixes is that lamp_functional could be set to False, but there is nowhere in the code where lamp_functional could ever be set back to True. In the linked issue, sitting in the recharge station for copious amounts of time was also attempted with no success. E: Looking further into this, I can't find any instances of lamp_cooldown being changed after initialization, and smash_headlamp is only ever called by shadowling/shadowperson abilities |
ToasterBiome
approved these changes
Mar 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
Before this PR, replacing a borg's headlamp by placing a new bulb in would simply set the lamp's cooldown value to 0. This means that if the bulb was smashed, for example by a shadowling's light eater attack, replacing the bulb would not actually make the lamp functional again. This PR sets lamp_functional to True on top of reducing the cooldown to 0, which should actually fix the headlamp upon replacing the bulb.
Fixes #13504
Tested locally, works
Wiki Documentation
The replacement of a borg's lamp doesn't seem to be documented on the wiki, at least in the guide to robotics. It is possible to replace a borg's bulb by simply opening its cover and placing a new bulb inside just as if you were placing a new cell in a borg.
Changelog
🆑 NovaAzure
bugfix: Placing a new bulb into a borg fixes their headlamp
/:cl: