Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Bloodsucker fixes + balance + new clan + ports some stuff - #13918

Merged
JamieD1 merged 21 commits into
yogstation13:masterfrom
tattax:i
May 10, 2022
Merged

Bloodsucker fixes + balance + new clan + ports some stuff#13918
JamieD1 merged 21 commits into
yogstation13:masterfrom
tattax:i

Conversation

@tattax

@tattax tattax commented Apr 28, 2022

Copy link
Copy Markdown
Contributor

fulpstation/fulpstation#588
fulpstation/fulpstation#529
fulpstation/fulpstation#617
fulpstation/fulpstation#626

Document the changes in your pull request

  • Add new objectives
  • Change stuff with initial feedback from github
  • Finish un-placeholding and documenting stuff properly

New bloodsucker stuff + trying to fix some thing that the community complained about.

NEW

Clan Lasombra: Interaction with a new Resting Place structure to spend ranks in order to be able to ascend normal abilities to a higher level and gain some attributes, they can also see heretic influences and harvest things from them. Fav. Vassal gets shadowwalk and minor glare.

Shadow Abilities: Upgraded versions of normal abilities limited to the previous clan.

Possessed armor trap for Lasombra Bloodsuckers that trigger when passerbys get too close and personal.

Gangrel Clan when entering frenzy goes wolf mode, which depending on your current powers gives you certain powers, always have feast so you can have a way of getting out of frenzy. Some unexpected things can happen when leaving frenzy though...

Clan Tzimisce: Midround with different interactions with a vassal rack with the ability to dice corpses to obtain muscles to fuel powerful creations.

TWEAKED

Gangrel Clan can now stack transforms if you can't level up to the next level, making it so you don't waste 100 blood and get refunded about 3/4 and 1/4 on level 1 and 2 respectively, giving you minor buffs if you are transformed.

Tweaked how werewolf form acted to fit the new style i'm trying to give the Gangrel Clan since it was previously kind of lackluster

Bloodsuckers now enter frenzy at a higher blood level to encourage blood drinking.

Night cycle changed from 10 mins -> 15 mins and Day 1 min -> 45 secs (Day might be changed back but i'm not sure) due to having too much back and in, also reducing rank gain to encourage usage of the blood altar. (Which had it's construction price reduced).

Bloodsuckers should now be immune to brute when in torpor, might need some testing.

Tweaked feed objective's amount as that was made before i made 2/3 objectives per sucker.

Powers now also show cooldowns.

Most bloodsucker mobs health reduced severely.

FIXES

Should fix most bugs related to objectives, also tries to resolve some of the monsterhunter objectives issues and makes them respect quiet round.

Wiki Documentation

New clan (x2) + gangrel changes + probably want to apply structures there

Changelog

🆑 JohnFulpWillard, SmoSmoSmoSmok, Tatax
rscadd: Two new bloodsucker clans (Lasombra & Tzimisce), Gangrel Clan's wolf form actual implementation
bugfix: Maybe possibly fixed some bloodsucker bugs
tweak: Gangrel Clan now has a refund system if you transform on the same blood level, also Day and Night Cycle's time and frenzy rebalances
imageadd: New sprite for powers and traps!
spellcheck: fixed the forck
/:cl:

@Yogbot-13 Yogbot-13 added Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs Tweak This PR contains changes to the game. labels Apr 28, 2022
@ghost

ghost commented Apr 28, 2022

Copy link
Copy Markdown

Can you also make that when you suck blood as a bloodsucker there will be a progress bar like normal vampires have, because it is confusing, and hard to understand are you sucking blood or not

@tattax

tattax commented Apr 28, 2022

Copy link
Copy Markdown
Contributor Author

Can you also make that when you suck blood as a bloodsucker there will be a progress bar like normal vampires have, because it is confusing, and hard to understand are you sucking blood or not

it gives the prog bar when you are starting the suck, after that you're always draining blood, vampire does it in waves

@NCRLouTenant

Copy link
Copy Markdown

As a VtM fan I am always excited for Bloodsucker improvements and additions.

@tattax
tattax marked this pull request as ready for review April 29, 2022 01:12
@tattax
tattax requested a review from a team as a code owner April 29, 2022 01:12
@ghost

ghost commented Apr 29, 2022

Copy link
Copy Markdown

Also what effect's do heretic influences give to bloodsuckers?

@tattax

tattax commented Apr 29, 2022

Copy link
Copy Markdown
Contributor Author

Also what effect's do heretic influences give to bloodsuckers?

new item to activate the structure

@bruhlookatthisdood

bruhlookatthisdood commented Apr 30, 2022

Copy link
Copy Markdown
Contributor

You can suck blood from an xenomorph and get blood out of it
its literaly acid
wtf
(me asking you to fix this)

Yogbot-13 added a commit that referenced this pull request Apr 30, 2022
@SomeguyManperson

Copy link
Copy Markdown
Contributor

You can suck blood from an xenomorph and get blood out of it its literaly acid wtf (me asking you to fix this)

skill issue

@ghost

ghost commented May 1, 2022

Copy link
Copy Markdown

You can suck blood from an xenomorph and get blood out of it

its literaly acid

wtf

(me asking you to fix this)

Upload.from.GitHub.for.iOS.MOV

Comment thread code/modules/antagonists/bloodsuckers/bloodsucker_mobs.dm Outdated
@tattax
tattax requested a review from a team as a code owner May 2, 2022 14:17
Yogbot-13 added a commit that referenced this pull request May 2, 2022
Comment thread code/modules/antagonists/bloodsuckers/bloodsucker_mobs.dm Outdated
tattax and others added 2 commits May 2, 2022 21:08
Co-authored-by: Theos <theubernyan@gmail.com>
Comment thread code/modules/antagonists/bloodsuckers/powers/gangrel.dm Outdated
tattax added 5 commits May 6, 2022 01:33
fixes the issue of the heartbeat @Sniblet
runtimes stopped frenzy from applying the burn effect ( i didn't even know about it cause it doesn't say it anywhre lol) + masquerade runtimes + gangrel runtimes which fucked everything and coffin runtimes (coffins have had 0 armor for some time)
Yogbot-13 added a commit that referenced this pull request May 8, 2022
Yogbot-13 added a commit that referenced this pull request May 8, 2022
Yogbot-13 added a commit that referenced this pull request May 8, 2022
Yogbot-13 added a commit that referenced this pull request May 8, 2022
@UselessTheremin

Copy link
Copy Markdown
Contributor

btw heres this tatax #14002

@JamieD1 JamieD1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People throwing a fit

Comment thread config/game_options.txt Outdated
Comment thread config/game_options.txt Outdated
Comment thread config/game_options.txt Outdated
Comment thread config/game_options.txt Outdated
Yogbot-13 added a commit that referenced this pull request May 9, 2022
@tattax

tattax commented May 9, 2022

Copy link
Copy Markdown
Contributor Author

btw heres this tatax #14002

it's solved (should be)

@JamieD1
JamieD1 merged commit d99c370 into yogstation13:master May 10, 2022
Yogbot-13 added a commit that referenced this pull request May 10, 2022
@tattax
tattax deleted the i branch January 10, 2023 08:54
@tattax
tattax restored the i branch January 10, 2023 08:54
@JohnFulpWillard

Copy link
Copy Markdown
Member

You can suck blood from an xenomorph and get blood out of it

intentional, blood is blood


/obj/item/muscle/big
name = "big muscle piece"
desc = "I'm pretty sure it's owner needed this to live."

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its*

if(IS_BLOODSUCKER(user) && bloodsuckerdatum.my_clan == CLAN_TZIMISCE)
. += span_cult("By looking at it you comprehend that it would yield [size] points for ritual usage.")

/obj/item/muscle/attackby(obj/item/I, mob/user, params) // handles muscle crafting

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

single letter var

races += TRIPLECHEST_MONSTER
var/list/options = list()
options = races
var/answer = input(user, "We have the chance to mutate our Vassal, how should we mutilate their corpse? This will cost us blood.", "What do we do with our Vassal?") in options

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tgui_input

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throwing

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var/answer = input(user, "We have the chance to mutate our Vassal, how should we mutilate their corpse? This will cost us blood.", "What do we do with our Vassal?") in options

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Feature This adds new content to the game Fix This fixes an issue. Please link issues in fix PRs Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants