Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

fix grav code - #16895

Merged
Moltijoe merged 15 commits into
yogstation13:masterfrom
ShoziOffical:fix-grav
Dec 5, 2022
Merged

fix grav code#16895
Moltijoe merged 15 commits into
yogstation13:masterfrom
ShoziOffical:fix-grav

Conversation

@ShoziOffical

@ShoziOffical ShoziOffical commented Dec 1, 2022

Copy link
Copy Markdown
Contributor

fix #14882, fix #14784, fix #14786
When you drag object in space and stop at one point, the object itself doesn't stop and still moving which is bad. Since SM can dust if hits something, this can be even worse.

ported a fix from tg

Document the changes in your pull request

fix pulling shit in 0G being wonky

Changelog

🆑

bugfix: fixed pulling shit in 0G being wonky
/:cl:

@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label Dec 1, 2022
@ShoziOffical

Copy link
Copy Markdown
Contributor Author

what the fuck

@ShoziOffical

Copy link
Copy Markdown
Contributor Author

I hate turdis

@ReddicusDragon

Copy link
Copy Markdown
Contributor

does this literally add a check that says if the object is movable allow it to be moved if being pulled

@Simplehorror

Copy link
Copy Markdown
Contributor

didn't we do this before

@Bibby0110

Copy link
Copy Markdown
Contributor

shouldn't it just be based on ProcessSpacemove of pulledby

@ShoziOffical

ShoziOffical commented Dec 2, 2022

Copy link
Copy Markdown
Contributor Author

it supposed to be but someone removed it

@Simplehorror

Copy link
Copy Markdown
Contributor

are you sure this will work? shouldn't you just stop spaceglide in stop_pulling?

@ShoziOffical

ShoziOffical commented Dec 4, 2022

Copy link
Copy Markdown
Contributor Author

are you sure this will work? shouldn't you just stop spaceglide in stop_pulling?

this will work, i have tested, no need to stop spaceglide in stop_pulling

@ShoziOffical

Copy link
Copy Markdown
Contributor Author

@Simplehorror also thank you for adding sm bump code that instantly dusts everything it bumps to, gotta love when dragging it in 0G it dusts you if you stop at one point or will just keep moving till it dusts something

@Simplehorror

Copy link
Copy Markdown
Contributor

@Simplehorror also thank you for adding sm bump code that instantly dusts everything it bumps to, gotta love when dragging it in 0G it dusts you if you stop at one point or will just keep moving till it dusts something

ok so don't start dragging the supermatter into space?

@ShoziOffical

ShoziOffical commented Dec 4, 2022

Copy link
Copy Markdown
Contributor Author

@Simplehorror also thank you for adding sm bump code that instantly dusts everything it bumps to, gotta love when dragging it in 0G it dusts you if you stop at one point or will just keep moving till it dusts something

ok so don't start dragging the supermatter into space?

i said 0G not in space, and it is hella broken, not supposed to dust mob like that

Comment thread code/modules/mob/living/carbon/carbon_movement.dm Outdated
@ShoziOffical

Copy link
Copy Markdown
Contributor Author

ok so don't start dragging the supermatter into space?

you saying like you don't care about broken codes affecting gameplay

@Moltijoe
Moltijoe merged commit ba4f7a3 into yogstation13:master Dec 5, 2022
Yogbot-13 added a commit that referenced this pull request Dec 5, 2022
@ShoziOffical
ShoziOffical deleted the fix-grav branch January 1, 2025 01:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Fix This fixes an issue. Please link issues in fix PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pulling objects in no gravity with magboots bug can't drag shit like crate, canister, closet in space anymore Can't pull shit in space

6 participants