This repository was archived by the owner on May 22, 2025. It is now read-only.
Two-handed component - #19365
Merged
Merged
Conversation
this will require update_appearance to properly compile. Haven't ran updatepaths yet, I'm just saving my progress.
This reverts commit 6e4e79a.
Contributor
|
oh god bless, the nullrod jank workaround was the only clean way i could think of doing it |
tattax
added
Refactor
JohnFulpWillard
marked this pull request as ready for review
July 22, 2023 01:33
Yogbot-13
added a commit
that referenced
this pull request
Jul 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the changes in your pull request
This ports
/datum/component/two_handedfrom TG and some other minor things that were necessary for it to work.Currently there's a Null rod that's meant to be two-handed. Instead of having the component, it currently exists to be used in the Chaplain's null rod menu, then DELETES ITSELF when picked up, SPAWNS a NEW, COMPLETELY separate item with the SAME icon, name, attack verb, desc, strength, gives THAT item the antimagic component, then puts it in your hand. It's insane, it's crazy. It's... no longer needed.
Changelog
🆑
experimental: Added the two-handed component. Fireaxes, Double-bladed Eswords, Pitchforks, Binoculars, Baseball bats, etc. should all work the same, but now have a better backend that allows us to do more stuff with it, like making the Chaplain's null rod not delete itself upon being picked up.
/:cl: