Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Fixes some instances of improper init args - #19513

Merged
ToasterBiome merged 1 commit into
yogstation13:masterfrom
JohnFulpWillard:more-init-stuff
Jul 4, 2023
Merged

Fixes some instances of improper init args#19513
ToasterBiome merged 1 commit into
yogstation13:masterfrom
JohnFulpWillard:more-init-stuff

Conversation

@JohnFulpWillard

@JohnFulpWillard JohnFulpWillard commented Jul 3, 2023

Copy link
Copy Markdown
Member

Document the changes in your pull request

Some Initializes already had mapload into account in their args, they just did not have it named 'mapload'. This meant that when I added it, there were 2 mapload args, so things after it would not be put in order (see: disposals).

In basic terms: fixes disposals, gang tags, and nogene'd seeds.

image

Closes #19306
Closes #19400
Closes #19425

Changelog

🆑
fix: You can now build disposals again.
/:cl:

Some Initializes already had mapload into account in their args, they just did not have it named 'mapload'. This meant that when I added it, there were 2 mapload args, so things after it would not be put in order (see: disposals).
@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label Jul 3, 2023
@ShoziOffical

ShoziOffical commented Jul 4, 2023

Copy link
Copy Markdown
Contributor

link these issues too #19306 and #19425
same bugs

@JohnFulpWillard

Copy link
Copy Markdown
Member Author

Not sure if this fixes the first one, I'm not fixing invisibile tubes

@ShoziOffical

ShoziOffical commented Jul 4, 2023

Copy link
Copy Markdown
Contributor

Not sure if this fixes the first one, I'm not fixing invisibile tubes

it is invisible disposal not the the tube, when you place the disposal pipe using RPD its invisible its just like the same thing when you disconnect a disposal pipe

@ToasterBiome
ToasterBiome merged commit ea11fcb into yogstation13:master Jul 4, 2023
Yogbot-13 added a commit that referenced this pull request Jul 4, 2023
@JohnFulpWillard
JohnFulpWillard deleted the more-init-stuff branch October 23, 2023 10:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Fix This fixes an issue. Please link issues in fix PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to Repair Disposal Pipes rpd cant make disposals pipes anymore Invisible disposals pipes

4 participants