Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Partially Revert "Metallic hydrogen production now requires EFFORT (#15333)" and few adjustments - #19538

Merged
ToasterBiome merged 9 commits into
yogstation13:masterfrom
ShoziOffical:unfuck-metalh2
Jul 26, 2023
Merged

Partially Revert "Metallic hydrogen production now requires EFFORT (#15333)" and few adjustments#19538
ToasterBiome merged 9 commits into
yogstation13:masterfrom
ShoziOffical:unfuck-metalh2

Conversation

@ShoziOffical

@ShoziOffical ShoziOffical commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

This is still a nerf to it but less painful than the old nerf PR

The open tile methal hydrogen formation got nerfed so hard (nearly removing it at this point because no one tries this anymore) that you need approximately 2000-3000 h2 moles to get a single bar out of it which is so painful that atmosian has to used crystallizer instead. The reason to nerf this was to stop metal h2 golem spam (and also to nerf the production) but there was already a pr removing it from the metal h2 recipe #15295, so why making this even worse. It already required much efforts already: spending half hour into shift getting preparing the burn chamber, collecting water vapor, bz and getting the required temperature for the reaction to start

Document the changes in your pull request

  • Metallic hydrogen production now requires ~1/2 as many mols to start
  • Metallic hydrogen production hydrogen consumption is still about 70% of the total hydrogen required
  • Metallic hydrogen production BZ consumption now consume about 70% of the total bz required
  • Hydrogen min requirement is is reduced by 700 moles (Now the same as crystallizer recipe)
  • No more rng to metal h2 generation

Changelog

🆑
tweak: Metallic hydrogen production now requires ~1/2 as many mols to start
tweak: Metallic hydrogen production hydrogen consumption is still about 70% of the total hydrogen required
tweak: Metallic hydrogen production BZ consumption now consume about 70% of the total bz required
tweak: Hydrogen min requirement is is reduced by 700 moles (Now the same as crystallizer recipe)
tweak: No more rng to metal h2 generation
/:cl:

@ShoziOffical
ShoziOffical requested a review from monster860 as a code owner July 5, 2023 22:02
@Yogbot-13 Yogbot-13 added the Tweak This PR contains changes to the game. label Jul 5, 2023
@Mqiib

Mqiib commented Jul 5, 2023

Copy link
Copy Markdown
Contributor

Ok can you do the math and tell us what the actual number changes are? Also please the informative comments with updated ones that have the new numbers. They were there for a reason.

@wonderinghost

Copy link
Copy Markdown
Contributor

Well what about hydrogen production. That got cuffed hard

@ShoziOffical

Copy link
Copy Markdown
Contributor Author

Well what about hydrogen production. That got cuffed hard

you mean metallic hydrogen production? i just updated it you can look it in the document

@ShoziOffical

Copy link
Copy Markdown
Contributor Author

Ok can you do the math and tell us what the actual number changes are? Also please the informative comments with updated ones that have the new numbers. They were there for a reason.

there you go

@wonderinghost

Copy link
Copy Markdown
Contributor

Well what about hydrogen production. That got cuffed hard

you mean metallic hydrogen production? i just updated it you can look it in the document

No
Hydrogen. The gas
Before you could make metric tons of hydrogen from one water can but now you can't

@ShoziOffical

Copy link
Copy Markdown
Contributor Author

Well what about hydrogen production. That got cuffed hard

you mean metallic hydrogen production? i just updated it you can look it in the document

No Hydrogen. The gas Before you could make metric tons of hydrogen from one water can but now you can't

that got fixed #18671

@Mqiib

Mqiib commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

I'm still really not a fan of removing the logarithmic scaling for the temperature. As linear you more or less hit the maximum immediately with even less effort. Also, approximately how much faster is metallic hydrogen produced with this pr compared to how it was before, given the same ideal conditions?

@ShoziOffical

Copy link
Copy Markdown
Contributor Author

I'm still really not a fan of removing the logarithmic scaling for the temperature. As linear you more or less hit the maximum immediately with even less effort. Also, approximately how much faster is metallic hydrogen produced with this pr compared to how it was before, given the same ideal conditions?

like when before your pr or after your pr

@Mqiib

Mqiib commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

I'm still really not a fan of removing the logarithmic scaling for the temperature. As linear you more or less hit the maximum immediately with even less effort. Also, approximately how much faster is metallic hydrogen produced with this pr compared to how it was before, given the same ideal conditions?

like when before your pr or after your pr

As in comparing to just before this pr.

@ShoziOffical

ShoziOffical commented Jul 7, 2023

Copy link
Copy Markdown
Contributor Author

As in comparing to just before this pr.

it will be just like crystallizer production rate or a bit faster i believe so people can try out both ways without having one obsolete

@Mqiib

Mqiib commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

As in comparing to just before this pr.

it will be just like crystallizer production rate or a bit faster i believe

I mean as in a relative comparison, like "It will generate metallic hydrogen [number] times faster than before, given the same setup and input"

@ShoziOffical
ShoziOffical marked this pull request as draft July 7, 2023 20:39
@ShoziOffical

Copy link
Copy Markdown
Contributor Author

As in comparing to just before this pr.

it will be just like crystallizer production rate or a bit faster i believe

I mean as in a relative comparison, like "It will generate metallic hydrogen [number] times faster than before, given the same setup and input"

approximately about 3 times faster

@Mqiib

Mqiib commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

3x is fine considering the hydrogen nerf, but I still think the logarithmic heat scale should remain.

@ShoziOffical

Copy link
Copy Markdown
Contributor Author

3x is fine considering the hydrogen nerf, but I still think the logarithmic heat scale should remain.

im currently testing with it

@ShoziOffical

Copy link
Copy Markdown
Contributor Author

okay maybe i will add it back

@ShoziOffical
ShoziOffical marked this pull request as ready for review July 7, 2023 21:10
@ShoziOffical

Copy link
Copy Markdown
Contributor Author

@Mqiib there ya go

@Moltijoe Moltijoe added the Awaiting - Action - Balance Review Code Director Review label Jul 22, 2023
@Moltijoe Moltijoe added Balance Council Approved This PR was approved by the Balance Council. and removed Awaiting - Action - Balance Review Code Director Review labels Jul 24, 2023
@ShoziOffical

Copy link
Copy Markdown
Contributor Author

based council

@ToasterBiome
ToasterBiome merged commit c2aa951 into yogstation13:master Jul 26, 2023
Yogbot-13 added a commit that referenced this pull request Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Balance Council Approved This PR was approved by the Balance Council. Tweak This PR contains changes to the game.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants