Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Removing/Extracting IPC's Positron Brain Properly Moves Mind To Brain#21145

Merged
Moltijoe merged 1 commit into
yogstation13:masterfrom
Runian:why-this-noclone-runtime
Dec 21, 2023
Merged

Removing/Extracting IPC's Positron Brain Properly Moves Mind To Brain#21145
Moltijoe merged 1 commit into
yogstation13:masterfrom
Runian:why-this-noclone-runtime

Conversation

@Runian

@Runian Runian commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

Document the changes in your pull request

Fixes runtime involving setting no clone status trait which caused minds not to be transferred when brain was removed.
Closes #21026
Closes #20628
Closes #20416
Closes #20336

Testing

Mind is moved to brain when IPC brain is removed. Gibbing IPC causes mind to move to IPC brain. No runtime.

Changelog

🆑
bugfix: Removing/extracting IPC's positron brain properly moves their mind.
/:cl:

@Yogbot-13 Yogbot-13 added the Fix This fixes an issue. Please link issues in fix PRs label Dec 20, 2023
Moltijoe
Moltijoe approved these changes Dec 20, 2023
View reviewed changes

@Moltijoe Moltijoe left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is tested?

@Moltijoe Moltijoe added the Awaiting - Merge This PR is ready for merge label Dec 20, 2023
@Runian

Runian commented Dec 20, 2023

Copy link
Copy Markdown
Contributor Author

this is tested?

I hope starting up Dream Daemon, self-surgery'ing a IPC's brain out, and proc'ing gib() wasn't part of my imagination.

@Moltijoe

Moltijoe commented Dec 20, 2023

Copy link
Copy Markdown
Contributor

I hope starting up Dream Daemon, self-surgery'ing a IPC's brain out, and proc'ing gib() wasn't part of my imagination.

you never know

@Moltijoe
Moltijoe merged commit aeabbf5 into yogstation13:master Dec 21, 2023
Yogbot-13 added a commit that referenced this pull request Dec 21, 2023
@Yogbot-13
Automatic changelog generation #21145 [ci skip]
db2ae58
@ofscarletdreams

ofscarletdreams commented Dec 21, 2023

Copy link
Copy Markdown

NOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO

@Runian
Runian deleted the why-this-noclone-runtime branch December 21, 2023 08:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@Moltijoe Moltijoe Moltijoe approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Awaiting - Merge This PR is ready for merge Fix This fixes an issue. Please link issues in fix PRs

Projects

None yet

Milestone

No milestone

4 participants

@Runian @Moltijoe @ofscarletdreams @Yogbot-13