Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Adds a signal technician clothing vendor - #7058

Closed
Ktlwjec wants to merge 5 commits into
yogstation13:masterfrom
Ktlwjec:veryniceclothesdear
Closed

Adds a signal technician clothing vendor#7058
Ktlwjec wants to merge 5 commits into
yogstation13:masterfrom
Ktlwjec:veryniceclothesdear

Conversation

@Ktlwjec

@Ktlwjec Ktlwjec commented Nov 10, 2019

Copy link
Copy Markdown
Contributor

The others get vendors but the signal tech was stuck with a wardrobe :( I absolutely hate the name of it though, if anyone has a better suggestion please let me know.

A proud Signal Technician after finally getting recognition from NT:
unknown

🆑
rscadd: Signal Technician's have a clothing vendor.
/:cl:

@Ktlwjec Ktlwjec added Feature This adds new content to the game Mapping Will result in a change to a map. labels Nov 10, 2019
@Ktlwjec
Ktlwjec requested a review from nesisknesis as a code owner November 10, 2019 15:22
@Readystorm546

Copy link
Copy Markdown
Contributor

I like this PR but im sad that i can no longer hide in that locker and set off a max cap during war opps. :(

@ynot01 ynot01 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i have no idea how reviews work but heres my name suggestion

Comment thread code/modules/vending/wardrobes.dm Outdated
machine_name = "AtmosDrobe"

/obj/machinery/vending/wardrobe/sigtech_wardrobe
name = "SigtechDrobe"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SigDrobe?

@MegaEmpirical

MegaEmpirical commented Nov 10, 2019

Copy link
Copy Markdown

I hate the vendrobes so much. This makes me incredibly sad. One of the last bastions of freedom left on the station dying.

@Xoxeyos

Xoxeyos commented Nov 11, 2019

Copy link
Copy Markdown
Contributor

Keep the locker, you can do alot more with it, such as you know, hiding in it, there aren't many places to hide on the sat.

@Hopekz

Hopekz commented Nov 11, 2019

Copy link
Copy Markdown
Contributor

Always thought that signal tech was a part of engineering in the past and since there is only one signal tech that locker kind of fit to cram all their shit in to.

I'm neutral as it is not a strong dislike just kind of feels out of place in my opinion.

@nesisknesis nesisknesis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that syd garland

@Ktlwjec

Ktlwjec commented Nov 16, 2019

Copy link
Copy Markdown
Contributor Author

To address concerns:
I'm changing the name to SigDrobe, it's what I had originally and it really does sound better.
I'll add a new locker to boxstation tcomms, so there will be the same amount of lockers there as before.
It's not about whether you like the vendors or not, it's a matter of consistency. As we got this from TG, there was no vendor made to replace the Signal Technician wardrobe. If there was, we would've added it in when the other lockers were replaced.

@Ktlwjec

Ktlwjec commented Nov 16, 2019

Copy link
Copy Markdown
Contributor Author

I'll just remake this, that is a brand new map copy idk what it's doing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Feature This adds new content to the game Mapping Will result in a change to a map.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants