Skip to content
This repository was archived by the owner on May 22, 2025. It is now read-only.

Ports Dynamic Gamemode Code from Beestation. - #8390

Merged
JamieD1 merged 83 commits into
yogstation13:masterfrom
Xoxeyos:Dynamic#1
Jun 14, 2020
Merged

Ports Dynamic Gamemode Code from Beestation.#8390
JamieD1 merged 83 commits into
yogstation13:masterfrom
Xoxeyos:Dynamic#1

Conversation

@Xoxeyos

@Xoxeyos Xoxeyos commented May 5, 2020

Copy link
Copy Markdown
Contributor

Ports over the Dynamic Gamemode Code from Beestation, I have tested it, all seems to be well. Some gamemodes are missing from Dynamic, such as gangs, but I could add that in later. Also a readme for documentation. The readme is in 'code\game\gamemodes\dynamic' .

🆑 Xoxeyos
rscadd: Ports over general dynamic code from Beestation. Thank you qwertyquerty, ShiftyRail, and Toxici11i for making this possible.
/🆑

@Xoxeyos

Xoxeyos commented May 5, 2020

Copy link
Copy Markdown
Contributor Author

Take a look here for some of what it does. tgstation/tgstation#44639

Also here for some images. https://imgur.com/a/KLqOdAY

Here is the Beestation PR, minor edits were needed to be made. https://github.com/BeeStation/BeeStation-Hornet/pull/399/files\

Here's /TG/s explaination on it. https://tgstation13.org/wiki/Game_Mode#Dynamic

Here's /VG/s explanation on the math behind it. However it may have very minor changes from our own.
vgstation-coders/vgstation13#22410

@github-actions github-actions Bot added the Admin This PR affects administrators label May 5, 2020
Xoxeyos added 4 commits May 5, 2020 01:58
code/game/gamemodes/dynamic/dynamic_rulesets_roundstart.dm, line 390, column 2:
error: possible unreachable code here
Comment thread code/game/gamemodes/dynamic/dynamic_rulesets_midround.dm Outdated
@ThatLing

ThatLing commented May 5, 2020

Copy link
Copy Markdown
Contributor

Some gamemodes are missing from Dynamic, such as gangs, but I could add that in later.

Why not add it now?

@Hopekz

Hopekz commented May 5, 2020

Copy link
Copy Markdown
Contributor

Why is this better?

@Xoxeyos

Xoxeyos commented May 5, 2020

Copy link
Copy Markdown
Contributor Author

Why is this better?

Please put more of an explanation into what you're asking.

@Xoxeyos

Xoxeyos commented May 5, 2020

Copy link
Copy Markdown
Contributor Author

Some gamemodes are missing from Dynamic, such as gangs, but I could add that in later.

Why not add it now?

I want to make sure this is well received, and has a test merge, before I add anything else in, to ensure I don't break anything.

@Hopekz

Hopekz commented May 5, 2020

Copy link
Copy Markdown
Contributor

Please put more of an explanation into what you're asking.

What does this provide over what we already have in terms of the experience?
"Why should this be merged?" a.k.a "Why is this better?"

@ghost

ghost commented May 5, 2020

Copy link
Copy Markdown

It should be merged because it's Dynamic Hopekz you sack of fuckwits

And the pr's from fucking TG, not bee

@Xoxeyos

Xoxeyos commented May 5, 2020

Copy link
Copy Markdown
Contributor Author

Please put more of an explanation into what you're asking.

What does this provide over what we already have in terms of the experience?
"Why should this be merged?" a.k.a "Why is this better?"

Well, I believe that this will be a fun and interesting gamemode, as it is easily configurable, using the administration game panel, and it will allow the community to give ideas on the subject, and hopefully give the community a good experience. It's also possible to add or remove antagonists, and side antagonists from the rolling list.

@Xoxeyos

Xoxeyos commented May 5, 2020

Copy link
Copy Markdown
Contributor Author

It should be merged because it's Dynamic Hopekz you sack of fuckwits

And the pr's from fucking TG, not bee

I used bee's code, as /TG/'s code has been heavily modified because of the direction of their codebase, bee is now more similar to our codebase. If I had used /TG/ code, I would have to edit several more files, as, for example, their mob.dm file has different variable names, unlike ours.

@Hopekz

Hopekz commented May 5, 2020

Copy link
Copy Markdown
Contributor

It should be merged because it's Dynamic Hopekz you sack of fuckwits

Compelling.

And the pr's from fucking TG, not bee

Better than your usual shitposts I'm awarding you a golden star
download

@alexkar598 alexkar598 added the Awaiting - Action - Maintainer This PR is awaiting an action from a maintainer label May 6, 2020
@Xoxeyos

Xoxeyos commented May 24, 2020

Copy link
Copy Markdown
Contributor Author

Adding some more stuff to vampire.

@Xoxeyos

Xoxeyos commented May 24, 2020

Copy link
Copy Markdown
Contributor Author

Adding some more shadowling stuff soon.

@Xoxeyos

Xoxeyos commented May 24, 2020

Copy link
Copy Markdown
Contributor Author

I'm ready for another test merge, or a merge.

@Xoxeyos
Xoxeyos requested a review from fluffe9911 June 3, 2020 18:32
Xoxeyos added 4 commits June 3, 2020 15:25
If set to TRUE, dynamic mode will be able to draft this ruleset again later on. (doesn't apply for roundstart rules(?))
@JamieD1
JamieD1 merged commit 0928d8e into yogstation13:master Jun 14, 2020
@Marmio64

Copy link
Copy Markdown
Contributor

why does it say vampire costs a whole fucking 25 points, but apparently lings and traitors are only 10?

@MegaEmpirical

Copy link
Copy Markdown

Vampires can reproduce? Could be why.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Admin This PR affects administrators Feature This adds new content to the game

Projects

None yet

Development

Successfully merging this pull request may close these issues.