Skip to content

Added ProjectFormat enum with specific for each version fields - #1566

Merged
yonaskolb merged 3 commits into
yonaskolb:masterfrom
anivaros:project-format
Mar 5, 2026
Merged

Added ProjectFormat enum with specific for each version fields#1566
yonaskolb merged 3 commits into
yonaskolb:masterfrom
anivaros:project-format

Conversation

@anivaros

Copy link
Copy Markdown
Contributor

Now Xcode selects correct Project Format

Screenshot 2025-07-22 at 17 51 36

Also added ability to specify version in options

public var tabWidth: UInt?
public var indentWidth: UInt?
public var xcodeVersion: String?
public var projectFormat: String?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yonaskolb I'm not sure about type
Maybe is better to move ProjectFormat to ProjectSpec and parse it here?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yonaskolb pls we need this

@anivaros

anivaros commented Nov 7, 2025

Copy link
Copy Markdown
Contributor Author

😢

@iradell

iradell commented Dec 10, 2025

Copy link
Copy Markdown

Can someone please review and merge this PR? We’re unable to generate with project format 16, so we urgently need this PR merged

@eddyg

eddyg commented Mar 3, 2026

Copy link
Copy Markdown

Any idea when this (and other valuable pending PRs) might get merged?

@yonaskolb

yonaskolb commented Mar 5, 2026

Copy link
Copy Markdown
Owner

Looks good. Some notes:

  • do we want to update this for Xcode 26+
  • having no parsing failures for unknown projectFormats might catch some people. Would be good if this failed

@yonaskolb

Copy link
Copy Markdown
Owner

Going to merge this now, @anivaros do you mind opening a PR for the notes above?

@yonaskolb
yonaskolb merged commit decc743 into yonaskolb:master Mar 5, 2026
3 checks passed
@anivaros

anivaros commented Mar 6, 2026

Copy link
Copy Markdown
Contributor Author

Looks good. Some notes:

  • do we want to update this for Xcode 26+
  • having no parsing failures for unknown projectFormats might catch some people. Would be good if this failed

@yonaskolb

  1. looks like there's no new format in Xcode 26
Screenshot 2026-03-06 at 12 57 17
  1. I'll add validation and tests in the new pr

@anivaros
anivaros deleted the project-format branch March 6, 2026 10:09
@shuguenot

shuguenot commented Mar 30, 2026

Copy link
Copy Markdown

New format is available with Xcode 26.x, see below

xcode

See #1620

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants