fix: Return empty string when token refresh fails - #263
Merged
Conversation
L-Joli
approved these changes
Aug 21, 2023
jonathannorris
added a commit
that referenced
this pull request
Jul 27, 2026
* chore: resolve open dependabot security alerts - fast-uri 3.1.2 -> 3.1.4 (high, alerts #275/#277) - sharp 0.34.5 -> 0.35.0 (high, alert #276) - @hono/node-server 1.19.13 -> 2.0.5 (medium, alert #274) - shell-quote 1.8.4 -> 1.9.0 (high, alert #273) - sigstore 1.9.0 -> 4.1.1 (high, alert #263) * chore: revert sharp bump due to new LGPL-licensed libvips artifact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently an error will be thrown if token refresh fails, even if the command does not require auth. If token refresh fails, log the error message but return an empty string as the token — the default "auth required" message will be displayed if necessary