DVC-8633: feat: add overrides update - #277
Merged
Merged
Conversation
Contributor
Author
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
suthar26
force-pushed
the
DVC-8633-add-overrides-update
branch
from
September 6, 2023 18:02
06ced91 to
4fd9bbc
Compare
suthar26
marked this pull request as ready for review
September 6, 2023 18:06
suthar26
force-pushed
the
DVC-8633-add-overrides-update
branch
from
September 6, 2023 18:06
4fd9bbc to
ac1382d
Compare
suthar26
force-pushed
the
DVC-8633-add-overrides-update
branch
2 times, most recently
from
September 6, 2023 18:08
29afd06 to
2603595
Compare
ajwootto
reviewed
Sep 6, 2023
| _environment: z.string(), | ||
| _feature: z.string(), | ||
| _variation: z.string(), | ||
| dvcUserId: z.string(), |
Contributor
There was a problem hiding this comment.
does this support empty strings, null and undefined?
Contributor
Author
There was a problem hiding this comment.
not sure, but we would only get the response for the UpdateCommand if all values are set and this is the return object
suthar26
force-pushed
the
DVC-8633-add-overrides-update
branch
from
September 6, 2023 18:13
2603595 to
93e9641
Compare
suthar26
force-pushed
the
DVC-8633-add-overrides-update
branch
from
September 6, 2023 19:20
93e9641 to
b368604
Compare
suthar26
enabled auto-merge (rebase)
September 6, 2023 19:23
chantalchung
reviewed
Sep 7, 2023
suthar26
force-pushed
the
DVC-8633-add-overrides-update
branch
2 times, most recently
from
September 7, 2023 17:52
8e820d3 to
7d3c24f
Compare
chantalchung
reviewed
Sep 7, 2023
suthar26
force-pushed
the
DVC-8633-add-overrides-update
branch
from
September 7, 2023 18:03
7d3c24f to
a24bcb2
Compare
chantalchung
approved these changes
Sep 7, 2023
jonathannorris
added a commit
that referenced
this pull request
Jul 27, 2026
* chore: resolve open dependabot security alerts - fast-uri 3.1.2 -> 3.1.4 (high, alerts #275/#277) - sharp 0.34.5 -> 0.35.0 (high, alert #276) - @hono/node-server 1.19.13 -> 2.0.5 (medium, alert #274) - shell-quote 1.8.4 -> 1.9.0 (high, alert #273) - sigstore 1.9.0 -> 4.1.1 (high, alert #263) * chore: revert sharp bump due to new LGPL-licensed libvips artifact
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.