Mock Mascot servlet for testing - #1077
Merged
Merged
Conversation
Make Mascot TestCase work on TeamCity
labkey-jeckels
approved these changes
Apr 17, 2020
labkey-jeckels
left a comment
labkey-jeckels
left a comment
Contributor
There was a problem hiding this comment.
One suggestion, but no further review needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The MS2 module includes integration with the Mascot search engine, but LabKey doesn't have a license to a Mascot server, so we have no way to test that integration. MockMascotServlet mimics a Mascot server by implementing a couple APIs that MascotClientImpl invokes. The primary motivation was to provide a way to test the only code in the product still using the 13-year-old commons HttpClient. With these tests in place, we can migrate this code to a modern HTTP library with confidence. See MascotClientImpl.TestCase.
Related Pull Requests
Changes