Remove remaining usages of commons HttpClient 3.1 - #159
Merged
Conversation
…ercises those APIs.
… (one to the Java HttpClient and the other to Apache HttpComponents). Remove commons HttpClient 3.1 from the product!
Make Mascot TestCase work on TeamCity
labkey-adam
changed the title
labkey-jeckels
approved these changes
Apr 17, 2020
cnathe
added a commit
that referenced
this pull request
Aug 3, 2026
…ontainer's @scripts dir (#1048) ## Rationale LabKey/internal-issues#159 See related PR for rationale. This PR fixes the Luminex tests so that they include their utility file in the `@scripts` dir when using the assay transform scripts. ## Related Pull Requests - LabKey/platform#7895 ## Changes - Luminex test fixes to add youtil.R file to `@scripts `dir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Commons HttpClient 3.1 was released and end-of-lifed 13 years ago. The last remaining LabKey code that uses this library is MascotClientImpl. The goal here is to remove these usages and eliminate this old, unsupported library from the product.
Related Pull Requests
Changes