Move build tooling from Humble to Jazzy - #36
Merged
griswaldbrooks merged 3 commits intoJul 30, 2026
Conversation
The cherry-pick onto jazzy-picknik carried the fork's build tooling over unchanged, so it still targeted Humble on Ubuntu 22.04. - Dockerfile: osrf/ros:humble-desktop-full -> jazzy-desktop-full, rmw-cyclonedds-cpp and setup.sh paths retargeted - entrypoint.sh: source /opt/ros/jazzy - CI + pre-commit: ubuntu-22.04 -> ubuntu-24.04, push trigger and the clang-tidy branch guard humble -> jazzy-picknik, setup-python 3.10 -> 3.12 to match Noble - README: state that this branch targets Jazzy Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gv6KUgyufFTvcUgVhLFAGo
dv-picknik
marked this pull request as draft
July 30, 2026 19:57
The pre-commit clang-format hook (pinned at v14.0.6) failed on five files
inherited by jazzy-picknik.
fuse_variables/test/test_load_device_id.cpp: my conflict resolution during
the replay hand-wrapped the UUID aggregate initializers. clang-format fills
to the column limit instead, so the continuation lines were re-wrapped.
fuse_core/{graph,message_buffer,timestamp_manager,transaction}.hpp: upstream
jazzy's Boost 1.90 any_range workaround (locusrobotics#424) indents the
guarded include; this fork's clang-format config wants it flush.
Verified by running clang-format 14.0.6 over the whole tree: these five files
are the complete set, no others drift.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Gv6KUgyufFTvcUgVhLFAGo
dv-picknik
marked this pull request as ready for review
July 30, 2026 20:25
clang-tidy runs only on files a PR touches. Reformatting this file in the previous commit pulled it into scope for the first time, surfacing 17 pre-existing misc-const-correctness findings: the eight `actual`/`expected` UUID pairs and `ret` in main. These predate this branch — they came over with the Humble replay — but the job is blocking, so they are fixed here rather than deferred. Declarations only; no behavioural change. Re-ran clang-format 14.0.6 afterwards since the added `const` pushed the initializer wrapping. Verified: clean build (0 warnings) and 849 tests, 0 failures, unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gv6KUgyufFTvcUgVhLFAGo
griswaldbrooks
approved these changes
Jul 30, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retargets the fork's build tooling from Humble to Jazzy.
jazzy-picknikwas created by replaying our 30 PickNik commits onto upstream'sjazzy, which carried the build tooling over verbatim — so a branch named for Jazzy was still building Humble on Ubuntu 22.04.Changes
osrf/ros:humble-desktop-full→jazzy-desktop-full,ros-humble-rmw-cyclonedds-cpp→ros-jazzy-...,setup.shpath/opt/ros/jazzyubuntu-22.04→ubuntu-24.04, push trigger and clang-tidy branch guardhumble→jazzy-picknik,setup-python3.10 → 3.12 to match Noblegit grep -iE 'humble|ubuntu-22|jammy'is now clean outsidedependencies/and changelogs.Verification
Both trees were built from scratch against Jazzy in Docker (
ros:jazzy-ros-base, wiped build volumes):jazzyjazzy-picknikThe warning diff between the two is empty. Extra packages on our side are the vendored submodules (
covariance_geometry_ros,tf2_2d).Caveats
Dockerfile. This PR opening is what actually tests theubuntu-24.04/jazzy-desktop-fullswitch.humble→jazzy-picknik, matching the old dev-branch convention. Change it ifjazzyis intended instead.Known follow-up, not in this PR
16 of our files still include tf2 headers upstream converted on jazzy in locusrobotics#416 (
tf2_ros/buffer.h,tf2/utils.h,tf2/convert.h,tf2/exceptions.h,tf2_ros/message_filter.h,tf2_ros/transform_broadcaster.h,tf2_ros/transform_listener.h), concentrated in the 3D models andtransform_sensor. Contrary to what you might expect, these produce no warnings on Jazzy — the.hshims still forward silently; the deprecation warnings land in Kilted/Rolling. So the.h→.hppconversion is future-proofing rather than a current-build fix, and is left for a separate PR.Refs PickNikRobotics/moveit_pro#20927
🤖 Generated with Claude Code
https://claude.ai/code/session_01Gv6KUgyufFTvcUgVhLFAGo