Bump version to 1.3.0 - #37
Merged
Merged
Conversation
The jazzy line inherited upstream jazzy's 1.1.5, which sorts below the 1.2.0-102 package already published to s3://picknik-apt. An unpinned 'apt install ros-jazzy-fuse' would therefore resolve to the older, ABI-broken build rather than this one. 1.3.0 clears 1.2.0 and places the jazzy line ahead of humble's 1.2.0.
Author
|
@dv-picknik @JWhitleyWork tell me if this bump seems right? I won't merge until one of you humans gets eyes on this. |
bkanator
marked this pull request as ready for review
July 31, 2026 12:40
dv-picknik
approved these changes
Jul 31, 2026
dv-picknik
left a comment
dv-picknik
left a comment
There was a problem hiding this comment.
Eww, the same version string in 13 files? O_o
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[written by AI]
Problem
jazzy-picknikinherited upstream jazzy's 1.1.5. The build farm has already publishedros-jazzy-fuse 1.2.0-102tos3://picknik-apt(the ABI-broken build from PickNikRobotics/moveit_pro#20927), and Debian version ordering puts 1.1.5 below it:So a package built from this branch would be older than the broken one it replaces. moveit_pro is unaffected — it pins exact versions and
apt-mark holds them — but an unpinnedapt install ros-jazzy-fuseresolves to the broken 1.2.0-102, and that stays "latest" in the repo indefinitely.Change
Bump all 13
package.xmlfiles 1.1.5 → 1.3.0. No other version references exist in the tree (checked*.txt,*.py,*.cfg).1.3.0 rather than 1.2.1: it clears 1.2.0 unambiguously and places the jazzy line ahead of
humble's 1.2.0, matching the fact that jazzy is now the forward line. Recommended by @JWhitleyWork.Tradeoff
This diverges from upstream jazzy's 1.1.x line, which #36 deliberately preserved. The alternative — staying at 1.1.5 and relying on exact pinning everywhere — was rejected because it leaves a known-broken package as the default resolution for anyone not pinning.
Follow-on
With the version changed, the build-farm revision should reset to 0 rather than continue at 103 (
1.3.0-0noblealready outranks1.2.0-102noble), per the revision convention indocs_nonpublic/Modifying-Build-Farm-Dependencies.md. PickNikRobotics/apt_build_farm#45 is drafted and will be updated to match.Refs PickNikRobotics/moveit_pro#20927