Update amber to depend on sub projects - #3111
Merged
Merged
Conversation
…Texera/texera into shengquan-flatten-micro-service
…Texera/texera into shengquan-flatten-micro-service
This reverts commit bc0c9bf.
This reverts commit 81f247e.
shengquan-ni
added a commit
that referenced
this pull request
Dec 2, 2024
Since #3111, amber has been built together with other micro-services. So we need to change the docker scripts and all other amber-related scripts to adapt this change. This PR updates those scripts. Important notes: 1. build-docker.sh is removed. We build everything using build-services.sh. 2. After building amber, we put the binary back into the amber folder for it to find `amberHomePath`. --------- Co-authored-by: Jiadong Bai <bobbaicloudwithpants@gmail.com>
Yicong-Huang
added a commit
that referenced
this pull request
Dec 2, 2024
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
This PR removes two copies of the code for workflow-core and workflow-operator and makes amber directly depend on those projects. Important points: 1. downgraded `snakeyaml` in `workflow-core` from 2.0 to 1.30 due to a conflict in `amber` project. 2. override all operator definitions in `workflow-compiling-service` with the latest changes in `amber`. Then deleted all operator definitions in `amber`. 3. we still have 2 implementations in `workflow-compiling-service` and `amber` for compilation. We should soon remove the implementation in `amber` Co-authored-by: Jiadong Bai <bobbaicloudwithpants@gmail.com> Co-authored-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com>
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
Since #3111, amber has been built together with other micro-services. So we need to change the docker scripts and all other amber-related scripts to adapt this change. This PR updates those scripts. Important notes: 1. build-docker.sh is removed. We build everything using build-services.sh. 2. After building amber, we put the binary back into the amber folder for it to find `amberHomePath`. --------- Co-authored-by: Jiadong Bai <bobbaicloudwithpants@gmail.com>
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
SarahAsad23
pushed a commit
to madisonmlin/texera
that referenced
this pull request
May 20, 2026
This PR removes two copies of the code for workflow-core and workflow-operator and makes amber directly depend on those projects. Important points: 1. downgraded `snakeyaml` in `workflow-core` from 2.0 to 1.30 due to a conflict in `amber` project. 2. override all operator definitions in `workflow-compiling-service` with the latest changes in `amber`. Then deleted all operator definitions in `amber`. 3. we still have 2 implementations in `workflow-compiling-service` and `amber` for compilation. We should soon remove the implementation in `amber` Co-authored-by: Jiadong Bai <bobbaicloudwithpants@gmail.com> Co-authored-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com>
SarahAsad23
pushed a commit
to madisonmlin/texera
that referenced
this pull request
May 20, 2026
) Since apache#3111, amber has been built together with other micro-services. So we need to change the docker scripts and all other amber-related scripts to adapt this change. This PR updates those scripts. Important notes: 1. build-docker.sh is removed. We build everything using build-services.sh. 2. After building amber, we put the binary back into the amber folder for it to find `amberHomePath`. --------- Co-authored-by: Jiadong Bai <bobbaicloudwithpants@gmail.com>
SarahAsad23
pushed a commit
to madisonmlin/texera
that referenced
this pull request
May 20, 2026
apache#3111 caused changes in apache#3059 being reverted. This PR applies the changes again.
yangzhang75
pushed a commit
to yangzhang75/texera
that referenced
this pull request
Jun 22, 2026
This PR removes two copies of the code for workflow-core and workflow-operator and makes amber directly depend on those projects. Important points: 1. downgraded `snakeyaml` in `workflow-core` from 2.0 to 1.30 due to a conflict in `amber` project. 2. override all operator definitions in `workflow-compiling-service` with the latest changes in `amber`. Then deleted all operator definitions in `amber`. 3. we still have 2 implementations in `workflow-compiling-service` and `amber` for compilation. We should soon remove the implementation in `amber` Co-authored-by: Jiadong Bai <bobbaicloudwithpants@gmail.com> Co-authored-by: Yicong Huang <17627829+Yicong-Huang@users.noreply.github.com>
yangzhang75
pushed a commit
to yangzhang75/texera
that referenced
this pull request
Jun 22, 2026
) Since apache#3111, amber has been built together with other micro-services. So we need to change the docker scripts and all other amber-related scripts to adapt this change. This PR updates those scripts. Important notes: 1. build-docker.sh is removed. We build everything using build-services.sh. 2. After building amber, we put the binary back into the amber folder for it to find `amberHomePath`. --------- Co-authored-by: Jiadong Bai <bobbaicloudwithpants@gmail.com>
yangzhang75
pushed a commit
to yangzhang75/texera
that referenced
this pull request
Jun 22, 2026
apache#3111 caused changes in apache#3059 being reverted. This PR applies the changes again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes two copies of the code for workflow-core and workflow-operator and makes amber directly depend on those projects.
Important points:
snakeyamlinworkflow-corefrom 2.0 to 1.30 due to a conflict inamberproject.workflow-compiling-servicewith the latest changes inamber. Then deleted all operator definitions inamber.workflow-compiling-serviceandamberfor compilation. We should soon remove the implementation inamber