Update docker scripts due to the change of folder structure - #3134
Merged
Conversation
bobbai00
self-requested a review
December 2, 2024 05:51
bobbai00
approved these changes
Dec 2, 2024
bobbai00
left a comment
bobbai00
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I fix the deploy-daemon script.
shengquan-ni
changed the title
PurelyBlank
pushed a commit
that referenced
this pull request
Dec 4, 2024
Since #3111, amber has been built together with other micro-services. So we need to change the docker scripts and all other amber-related scripts to adapt this change. This PR updates those scripts. Important notes: 1. build-docker.sh is removed. We build everything using build-services.sh. 2. After building amber, we put the binary back into the amber folder for it to find `amberHomePath`. --------- Co-authored-by: Jiadong Bai <bobbaicloudwithpants@gmail.com>
SarahAsad23
pushed a commit
to madisonmlin/texera
that referenced
this pull request
May 20, 2026
) Since apache#3111, amber has been built together with other micro-services. So we need to change the docker scripts and all other amber-related scripts to adapt this change. This PR updates those scripts. Important notes: 1. build-docker.sh is removed. We build everything using build-services.sh. 2. After building amber, we put the binary back into the amber folder for it to find `amberHomePath`. --------- Co-authored-by: Jiadong Bai <bobbaicloudwithpants@gmail.com>
yangzhang75
pushed a commit
to yangzhang75/texera
that referenced
this pull request
Jun 22, 2026
) Since apache#3111, amber has been built together with other micro-services. So we need to change the docker scripts and all other amber-related scripts to adapt this change. This PR updates those scripts. Important notes: 1. build-docker.sh is removed. We build everything using build-services.sh. 2. After building amber, we put the binary back into the amber folder for it to find `amberHomePath`. --------- Co-authored-by: Jiadong Bai <bobbaicloudwithpants@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #3111, amber has been built together with other micro-services. So we need to change the docker scripts and all other amber-related scripts to adapt this change. This PR updates those scripts.
Important notes:
amberHomePath.