feat: switch workflow result downloads to use browser native downloads by madisonmlin · Pull Request #3728 · apache/texera

madisonmlin · 2025-09-11T18:47:14Z

Purpose

This pull request partially addresses issue #3404 by switching workflow result downloads to use the browser's native download functionality. Using the browser to handle downloads enables the browser's built-in download UI, including a progress bar when downloading larger files.

Changes

Previously, we used Angular's HttpClient to request the result file from the backend as a Blob and download the Blob to the local filesystem. Now, we use a standard HTML form submission to request the result file, allowing the browser to handle the download. The backend logic for generating the file stream remains the same.

Headers such as Authorization (used for Bearer tokens) cannot be added to standard form submissions. To work around this, we pass the JWT token directly as a form parameter and manually check for validity of the token in the backend. We also manually verify that the user role is valid.

Summary of Changes

Changed frontend logic for local workflow result downloads to use a standard form submission instead of HttpClient to request the download, allowing the browser to handle the download
Added endpoint to receive form request and authenticate the request via the JWT token before triggering download

Demonstration

texera_workflow_result_download_demo.mp4

…oads

…al vs. dataset download

… of requesting backend token

…ultExportService

…oints

…a single function

chenlica · 2025-09-29T04:41:30Z

@kunwp1 Please review this PR after @aicam's pass.

…ype (local, dataset)

… list

…s-bar

…made in frontend

…ithub.com:madisonmlin/texera into enable-workflow-single-file-download-progress-bar

…s-bar

kunwp1

The changes look good! Thanks.

aicam · 2025-10-07T02:44:34Z

@madisonmlin I test it on staging and merge, thanks

…s-bar

…nload-progress-bar' into enable-workflow-single-file-download-progress-bar # Conflicts: # core/amber/src/main/scala/edu/uci/ics/texera/web/resource/dashboard/user/workflow/WorkflowExecutionsResource.scala # core/gui/src/app/dashboard/service/user/download/download.service.ts # core/gui/src/app/workspace/service/workflow-result-export/workflow-result-export.service.ts

kunwp1 · 2025-10-10T16:15:43Z

@madisonmlin Please merge the PR once you resolve the conflicts. Thanks!

…s-bar Signed-off-by: Xinyuan Lin <xinyual3@uci.edu>

…nload-progress-bar' into enable-workflow-single-file-download-progress-bar

aicam · 2025-10-11T00:40:28Z

I just fixed the Kubernetes deployment @kunwp1

…o be separate and symmetric (#3916) ### What changes were proposed in this PR? This PR updates the function names and docstring for workflow result exports to local/dataset to be symmetric. ### Any related issues, documentation, discussions? Refactors #3728. ### How was this PR tested? This PR involves a simple refactoring of the existing workflow result export functionality. Apart from verifying that the functionality has not changed, no additional tests are needed. ### Was this PR authored or co-authored using generative AI tooling? No.

apache#3728) ### Purpose ### This pull request partially addresses issue apache#3404 by switching workflow result downloads to use the browser's native download functionality. Using the browser to handle downloads enables the browser's built-in download UI, including a progress bar when downloading larger files. ### Changes ### Previously, we used Angular's `HttpClient` to request the result file from the backend as a `Blob` and download the `Blob` to the local filesystem. Now, we use a standard HTML form submission to request the result file, allowing the browser to handle the download. The backend logic for generating the file stream remains the same. Headers such as `Authorization` (used for Bearer tokens) cannot be added to standard form submissions. To work around this, we pass the JWT token directly as a form parameter and manually check for validity of the token in the backend. We also manually verify that the user role is valid. #### Summary of Changes #### - Changed frontend logic for local workflow result downloads to use a standard form submission instead of `HttpClient` to request the download, allowing the browser to handle the download - Added endpoint to receive form request and authenticate the request via the JWT token before triggering download ### Demonstration ### https://github.com/user-attachments/assets/a2d5278e-5ebf-441f-99bf-ff93d1667271 --------- Signed-off-by: Xinyuan Lin <xinyual3@uci.edu> Co-authored-by: Chris <143021053+kunwp1@users.noreply.github.com> Co-authored-by: ali risheh <ali.risheh876@gmail.com> Co-authored-by: ali <a_icam@yahoo.com> Co-authored-by: Xinyuan Lin <xinyual3@uci.edu>

…o be separate and symmetric (apache#3916) ### What changes were proposed in this PR? This PR updates the function names and docstring for workflow result exports to local/dataset to be symmetric. ### Any related issues, documentation, discussions? Refactors apache#3728. ### How was this PR tested? This PR involves a simple refactoring of the existing workflow result export functionality. Apart from verifying that the functionality has not changed, no additional tests are needed. ### Was this PR authored or co-authored using generative AI tooling? No.

apache#3728) ### Purpose ### This pull request partially addresses issue apache#3404 by switching workflow result downloads to use the browser's native download functionality. Using the browser to handle downloads enables the browser's built-in download UI, including a progress bar when downloading larger files. ### Changes ### Previously, we used Angular's `HttpClient` to request the result file from the backend as a `Blob` and download the `Blob` to the local filesystem. Now, we use a standard HTML form submission to request the result file, allowing the browser to handle the download. The backend logic for generating the file stream remains the same. Headers such as `Authorization` (used for Bearer tokens) cannot be added to standard form submissions. To work around this, we pass the JWT token directly as a form parameter and manually check for validity of the token in the backend. We also manually verify that the user role is valid. #### Summary of Changes #### - Changed frontend logic for local workflow result downloads to use a standard form submission instead of `HttpClient` to request the download, allowing the browser to handle the download - Added endpoint to receive form request and authenticate the request via the JWT token before triggering download ### Demonstration ### https://github.com/user-attachments/assets/a2d5278e-5ebf-441f-99bf-ff93d1667271 --------- Signed-off-by: Xinyuan Lin <xinyual3@uci.edu> Co-authored-by: Chris <143021053+kunwp1@users.noreply.github.com> Co-authored-by: ali risheh <ali.risheh876@gmail.com> Co-authored-by: ali <a_icam@yahoo.com> Co-authored-by: Xinyuan Lin <xinyual3@uci.edu>

…o be separate and symmetric (apache#3916) ### What changes were proposed in this PR? This PR updates the function names and docstring for workflow result exports to local/dataset to be symmetric. ### Any related issues, documentation, discussions? Refactors apache#3728. ### How was this PR tested? This PR involves a simple refactoring of the existing workflow result export functionality. Apart from verifying that the functionality has not changed, no additional tests are needed. ### Was this PR authored or co-authored using generative AI tooling? No.

aicam self-requested a review September 11, 2025 18:59

aicam assigned madisonmlin Sep 11, 2025

madisonmlin mentioned this pull request Sep 15, 2025

Switch workflow result download to use browser native downloads #3734

Closed

aicam linked an issue Sep 15, 2025 that may be closed by this pull request

Switch workflow result download to use browser native downloads #3734

Closed

aicam requested changes Sep 26, 2025

View reviewed changes

madisonmlin added 23 commits September 28, 2025 16:10

switch to native browser download for single-file dataset downloads

48eb166

remove old single-file dataset download methods and unit tests

6387da5

fix and format via scalafixall and scalafmtall

ef99281

fix format with prettier and eslint

599f633

(incomplete) enable browser native download for workflow result downl…

1231747

…oads

(complete) enable browser native download for workflow result downloads

c5fef5a

add user role filtering to workflow result export endpoint

737c18f

remove unrelated s3 presigned url generation logic

acc9fe8

remove unrelated s3 presigned url generation logic

ef9a4bc

remove unrelated single file dataset download logic

1d4577c

add Apache License header to new files

ce67686

remove old workflow result download logic for single file downloads

3cd9cef

update paths of workflow result download endpoints to distinguish loc…

13c6d03

…al vs. dataset download

change authentication method to use localStorage access token instead…

ad87153

… of requesting backend token

remove files and changes for old authentication method (backend token)

13a6497

remove unused jwtDownloadClaims from JwtAuth

892c13f

remove changes to JwtAuth

0ef5684

move helper functions for local and dataset export endpoints into Res…

c76fa3c

…ultExportService

remove unnecessary initializations of ResultExportService class

78a812d

add descriptions for helper functions for workflow result export endp…

0441023

…oints

combine related dataset export functions in ResultExportService into …

45089cf

…a single function

remove redundant check for if no operators are specified

7c0a940

run scalafixAll and scalafmtAll

7fe4a70

madisonmlin force-pushed the enable-workflow-single-file-download-progress-bar branch from e9b290c to 7fe4a70 Compare September 28, 2025 23:27

change workflow result export endpoint names to specify destination t…

09c99ca

…ype (local, dataset)

github-actions Bot added engine frontend Changes related to the frontend GUI labels Oct 6, 2025

madisonmlin and others added 6 commits October 5, 2025 20:59

remove unnecessary validation method checking for non-empty operators…

8ae4e19

… list

fix and format with scalafixAll and scalafmtAll

0de2964

Merge branch 'main' into enable-workflow-single-file-download-progres…

e3ae26c

…s-bar

remove unnecessary backend checks for empty operators list; check is …

38bef8f

…made in frontend

Merge branch 'enable-workflow-single-file-download-progress-bar' of g…

b709202

…ithub.com:madisonmlin/texera into enable-workflow-single-file-download-progress-bar

Merge branch 'main' into enable-workflow-single-file-download-progres…

d53951c

…s-bar

kunwp1 approved these changes Oct 7, 2025

View reviewed changes

aicam and others added 2 commits October 9, 2025 13:04

Merge branch 'main' into enable-workflow-single-file-download-progres…

04fefa2

…s-bar

aglinxinyuan and others added 3 commits October 10, 2025 17:09

Merge branch 'main' into enable-workflow-single-file-download-progres…

eec7c09

…s-bar Signed-off-by: Xinyuan Lin <xinyual3@uci.edu>

fix: K8S and acs

1eaf248

Merge remote-tracking branch 'madison/enable-workflow-single-file-dow…

3faf347

…nload-progress-bar' into enable-workflow-single-file-download-progress-bar

github-actions Bot added dependencies Pull requests that update a dependency file infra labels Oct 11, 2025

aicam added 2 commits October 10, 2025 19:03

fix: test case

e7f83e4

fix: merge

2ee0db5

aicam merged commit 1317199 into apache:main Oct 11, 2025
11 checks passed

madisonmlin mentioned this pull request Oct 16, 2025

refactor: update workflow result export functions for local/dataset to be separate and symmetric #3916

Merged

aglinxinyuan mentioned this pull request May 8, 2026

chore(deps): drop unused content-disposition dependency #4980

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: switch workflow result downloads to use browser native downloads - #3728

feat: switch workflow result downloads to use browser native downloads#3728
aicam merged 68 commits into
apache:mainfrom
madisonmlin:enable-workflow-single-file-download-progress-bar

madisonmlin commented Sep 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chenlica commented Sep 29, 2025

Uh oh!

kunwp1 left a comment

Uh oh!

aicam commented Oct 7, 2025

Uh oh!

kunwp1 commented Oct 10, 2025

Uh oh!

aicam commented Oct 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

madisonmlin commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Changes

Summary of Changes

Demonstration

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chenlica commented Sep 29, 2025

Uh oh!

kunwp1 left a comment

Choose a reason for hiding this comment

Uh oh!

aicam commented Oct 7, 2025

Uh oh!

kunwp1 commented Oct 10, 2025

Uh oh!

aicam commented Oct 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

madisonmlin commented Sep 11, 2025 •

edited

Loading