refactor: update workflow result export functions for local/dataset to be separate and symmetric - #3916
Merged
aicam merged 2 commits intoOct 16, 2025
Conversation
aicam
marked this pull request as ready for review
October 16, 2025 22:57
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors workflow result export functions to improve naming consistency and clarity. The changes make the function names more explicit about their destination (dataset vs local) and update the documentation accordingly.
- Renamed
exportWorkflowResulttoexportWorkflowResultToDatasetto clarify its specific purpose - Updated the function's docstring to accurately describe that it exports to datasets specifically
- Updated the function call in the workflow result export service to use the new name
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| frontend/src/app/dashboard/service/user/download/download.service.ts | Renamed function and updated docstring to clarify dataset export functionality |
| frontend/src/app/workspace/service/workflow-result-export/workflow-result-export.service.ts | Updated function call to use the new renamed function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
aicam
enabled auto-merge (squash)
October 16, 2025 22:58
SarahAsad23
pushed a commit
to madisonmlin/texera
that referenced
this pull request
May 20, 2026
…o be separate and symmetric (apache#3916) ### What changes were proposed in this PR? This PR updates the function names and docstring for workflow result exports to local/dataset to be symmetric. ### Any related issues, documentation, discussions? Refactors apache#3728. ### How was this PR tested? This PR involves a simple refactoring of the existing workflow result export functionality. Apart from verifying that the functionality has not changed, no additional tests are needed. ### Was this PR authored or co-authored using generative AI tooling? No.
yangzhang75
pushed a commit
to yangzhang75/texera
that referenced
this pull request
Jun 22, 2026
…o be separate and symmetric (apache#3916) ### What changes were proposed in this PR? This PR updates the function names and docstring for workflow result exports to local/dataset to be symmetric. ### Any related issues, documentation, discussions? Refactors apache#3728. ### How was this PR tested? This PR involves a simple refactoring of the existing workflow result export functionality. Apart from verifying that the functionality has not changed, no additional tests are needed. ### Was this PR authored or co-authored using generative AI tooling? No.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this PR?
This PR updates the function names and docstring for workflow result exports to local/dataset to be symmetric.
Any related issues, documentation, discussions?
Refactors #3728.
How was this PR tested?
This PR involves a simple refactoring of the existing workflow result export functionality. Apart from verifying that the functionality has not changed, no additional tests are needed.
Was this PR authored or co-authored using generative AI tooling?
No.