Template, styles and behavior for bank-account component - #888
Conversation
joshsmith
left a comment
There was a problem hiding this comment.
I made some changes here.
|
|
||
| export default Component.extend({ | ||
| classNames: ['bank-account'] | ||
| classNames: ['bank-account__wrapper'], |
There was a problem hiding this comment.
Can we keep this named bank-account?
568403e to
b7fee7f
Compare
|
@begedin I didn't get to it but the I can go back through and make the green check icon work. Don't replicate that across the other issues. I'll fix it here, and introduce the new styles elsewhere. |
|
These will also need the actual values bound to the real values, and the account number last 4 will have to be used here instead, along with minor things I'm probably not mentioning. |
b7fee7f to
a826450
Compare
|
I did not use the route action for now, reason being I didn't want to potentially waste time and figuring out how to test that it's triggering properly. Instead, for now, the action is just passed out using closures. We can switch to the route action helper when we have the time. |
|
This took me longer than I thought due to me initially not realizing I need to implement the route action as well. I thought it would be just the component, not the whole logic chain, so I went for this before doing the recipient part in the other issue. However, I got it as close as possible. The process consists of two steps - creating a token and adding the external account to the stripe connect account. Each step catches and handles it's own errors (a friendly string is displayed, similar to how it's done on the donate page. Token creation was tested manually. Adding the account to our api record is untested and might need adjustments, but seems pretty straightforward for now. An acceptance test will be need it. We can write it once we figure out the API parts and know the names of properties. Not sure if that's going to be part of this PR, or separate. |
Bind to properties and actions Added error rendering, busy state, action handling at route level Add icon for verified accounts Fix project settings menu
2ddca95 to
93a5da9
Compare
What's in this PR?
Updates to bank-account component.
Notes
TODO
ember-stripe-servicetoken generationReferences
Fixes #860