Rework funds-recipient into a wrapper - #890
Merged
Merged
Conversation
joshsmith
force-pushed
the
868-rework-funds-recipient-wrapper
branch
from
December 17, 2016 20:27
95f8042 to
0ec77de
Compare
…ate subcomponents based on status
joshsmith
force-pushed
the
868-rework-funds-recipient-wrapper
branch
from
December 17, 2016 20:30
0ec77de to
19970b8
Compare
joshsmith
approved these changes
Dec 17, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Rewrites funds-recipient component into a wrapper based on requirements in 868.
I'm not assuming usage of
route-actiondue to me not trying to test it yet. If we want to use it in this PR and the respective subcomponents, it should be trivial to remove thepassthrough.For now, instead of rendering subcomponents, we just render placeholders with appropriate class names.
There are no styles yet. Part of the styles can be taken over from #888. The rest can be done in a separate issue, or here.
References
Fixes #868