Skip to content

Remove duplicate settings menus - #969

Merged
joshsmith merged 1 commit into
developfrom
947-disallow-activating-donations
Jan 13, 2017
Merged

Remove duplicate settings menus#969
joshsmith merged 1 commit into
developfrom
947-disallow-activating-donations

Conversation

@joshsmith

Copy link
Copy Markdown
Contributor

What's in this PR?

First move to remove duplicate settings menus.

Progress on #947

@joshsmith joshsmith added this to the Launch Donations milestone Jan 13, 2017
@joshsmith
joshsmith requested a review from begedin January 13, 2017 19:02
@joshsmith
joshsmith force-pushed the 947-disallow-activating-donations branch from 909da9d to 564c6f8 Compare January 13, 2017 19:04

@begedin begedin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a leftover comment, but looks good to merge otherwise.

Comment thread app/styles/_settings.scss Outdated

.settings {
@include span-columns(9.5);
// @include shift(2.5);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this line

@joshsmith
joshsmith merged commit 83937fa into develop Jan 13, 2017
@joshsmith
joshsmith deleted the 947-disallow-activating-donations branch January 13, 2017 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants