Add property to determine if device is compatible with Apple Pencil - #177
Add property to determine if device is compatible with Apple Pencil#177SomeRandomiOSDev wants to merge 2 commits into
Conversation
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
|
Nice! Don't know how @denisenepraunig would want to merge this with #168. Would also be cool to have a property that returns an enum with which Apple Pencil (1st/2nd gen) is supported on that device. Currently, the iPads only support one of the two, but this might change in the future. I think having it return an array of enums would future proof it so we won't have to introduce a breaking change in the future. |
|
@Zandor300 I really like this idea, much more than a simple boolean. I'll implement this and push an update to this PR |
…describe which generation of the Apple Pencil is supported
SomeRandomiOSDev
changed the title
|
I think it would be easier to merge this into master instead of swift-4.2 since we’ll be merging the 2.0 pr soon into master which uses Swift 5. I don’t actually know; is it possible to change this pr to merge to master instead? |
| public struct ApplePencilSupport: OptionSet { | ||
|
|
||
| public var rawValue: UInt | ||
| public init(rawValue: UInt) { |
There was a problem hiding this comment.
| Let and var should be separated from other statements by a blank line. |
|
Closed in lieu of PR against master: #178 |
3 participants
Added a property to the Device enum to determine is the given device can use the Apple Pencil. Current list of supported devices taken off of the Apple Pencil support page: https://support.apple.com/en-us/HT205236