Add property to determine if device is compatible with Apple Pencil - #178
Closed
SomeRandomiOSDev wants to merge 4 commits into
Closed
Add property to determine if device is compatible with Apple Pencil#178SomeRandomiOSDev wants to merge 4 commits into
SomeRandomiOSDev wants to merge 4 commits into
Conversation
added 3 commits
April 10, 2019 09:56
…describe which generation of the Apple Pencil is supported
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
# Conflicts: # Source/Device.generated.swift # Source/Device.swift.gyb
Collaborator
|
Hello @SomeRandomiOSDev! Could you please rebase your changes onto master - I have merged some breaking changes yesterday and there seem to be merge conflicts. Then I will review the changes, but so far so good and @Zandor300 already looked at the PR in the previous branch and it looked good to him. I will then merge this PR. |
Contributor
Author
|
Rebasing isn't working out so well due to conflicts between the master branch and these changes. I'm closing this and will open a new PR with my changes cherry picked after the latest changes on the master branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a property to the Device enum to determine is the given device can use the Apple Pencil and which version of the Apple Pencil is supported. Current list of supported devices taken off of the Apple Pencil support page: https://support.apple.com/en-us/HT205236