fixes from code review - #334
Merged
Merged
Conversation
rozyczko
added
[scope] enhancement
rozyczko
added a commit
that referenced
this pull request
Aug 3, 2026
* summary prettified (#308) * summary prettified * minor fixes after code review * make links clickable (#310) * Bayesian analysis (#309) * initial version. * updates to the parameter passing * nice Bayesian sub-tabs display * add parameter names, add cancellation of sampling, add number of steps in status bar * correct parenting * added required dependencies and modified Fit Status dialog * add save button to the plots * added tests for bayesian logic * attempt at getting posterior median and credibility intervals on the main chart * enable/disable legends on bayesian sampling * reload bumps images on recalculation. Use different caption when running sampling * updates and changes, new unit tests and GUI elements. New colors * fixed typo * actually sample multiple experiments * nicer plots * trace plot - nice display * updated plots * changes for the new EasyList based reflectometry-lib * changes after updates to core * unit test fixed * weird conflict * Bayesian fixes (#332) * removed MD file, fixed #312 * fixed #313 * Fixed issues #312 - #322 Temporarily commented out code signing * Addressed issues #323, #324, #325, #326 * addressed #327, #328, #329 * update paths in the Summary textboxes * minor updates based on the new ERL * summary results now show correct GoF #375 * reparent to released lib * fixes from code review (#334) * updated versioning (#335)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key changes ensure that Bayesian results are properly cleared when they become stale, the UI remains locked until background fitting threads actually exit, and late signals from superseded worker threads are safely ignored. Additional fixes address data handling for Bayesian sampling and parameter naming. Unused dependencies are also removed.
Bayesian Results Management
_clear_bayesian_resultsmethod and publicclearBayesianResultsslot, which is triggered by project state changes and fit/sampling starts. This method clears stored results, overlays, and emits appropriate signals.Fit Lifecycle and Thread Safety
_is_stale_worker_signalto ignore late signals from superseded worker threads, preventing them from mutating state after a new fit has started.Bayesian Sampling Robustness
yefalls back to zero variances with a clear message, and unusedxeis no longer attached to the Q coordinate.Parameter Naming and Tree Traversal
layerscontainer in the parameter-tree walker, avoiding mislabelling due to alias properties.Dependency Cleanup
cornerdependency from the project.