Skip to content

Core fixes pointwise - #387

Merged
rozyczko merged 2 commits into
core_fixesfrom
core_fixes_pointwise
Jul 30, 2026
Merged

Core fixes pointwise#387
rozyczko merged 2 commits into
core_fixesfrom
core_fixes_pointwise

Conversation

@rozyczko

Copy link
Copy Markdown
Member

Restoration of measured per-point resolution:
Updated the _apply_resolution_function method to set the model's resolution function to Pointwise when per-point q-resolution data (xe) is present; otherwise, it falls back to PercentageFwhm(5.0).

@rozyczko rozyczko added [scope] bug Bug report or fix (major.minor.PATCH) bugfix Fix to known bug [priority] high Should be prioritized soon labels Jul 29, 2026
@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.66%. Comparing base (5cb7b9d) to head (d2bf32a).

Files with missing lines Patch % Lines
src/easyreflectometry/project.py 25.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           core_fixes     #387   +/-   ##
===========================================
  Coverage       31.66%   31.66%           
===========================================
  Files              48       48           
  Lines            3840     3843    +3     
===========================================
+ Hits             1216     1217    +1     
- Misses           2624     2626    +2     
Flag Coverage Δ
integration 31.66% <25.00%> (+<0.01%) ⬆️
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyreflectometry/project.py 25.54% <25.00%> (+0.04%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rozyczko
rozyczko merged commit 3e1ef1c into core_fixes Jul 30, 2026
50 of 58 checks passed
@rozyczko
rozyczko deleted the core_fixes_pointwise branch July 30, 2026 13:21
rozyczko added a commit that referenced this pull request Jul 30, 2026
* moved to Sampler class from Core

* reparent branch

* fixed issue #367 (#382)

* fixed issue #367

* disable automatic parallelization for windows

* Changes after code review

* added test

* arviz fix

* try to fix prettier issues

* updated notebook

* linting

* fixing #370 (#388)

* reparent to develop

* Core fixes pointwise (#387)

* fixed pointwise treatment on file load

* more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fix to known bug [priority] high Should be prioritized soon [scope] bug Bug report or fix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant