Skip to content

fixing #370 - #388

Merged
rozyczko merged 1 commit into
core_fixesfrom
core_fixes_lsq_test
Jul 30, 2026
Merged

fixing #370#388
rozyczko merged 1 commit into
core_fixesfrom
core_fixes_lsq_test

Conversation

@rozyczko

Copy link
Copy Markdown
Member

Enhancements to error handling and user feedback:

  • The mcmc_sample function now raises a ValueError if all data points have zero variance (except when using the explicit 'mighell' objective), preventing undefined likelihoods. It also issues detailed warnings when the Mighell transform is applied, either to all points or to a subset with zero variance, clarifying the implications for the user.

@rozyczko rozyczko added [scope] bug Bug report or fix (major.minor.PATCH) bugfix Fix to known bug [priority] high Should be prioritized soon labels Jul 29, 2026
@codecov

codecov Bot commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.61%. Comparing base (5cb7b9d) to head (4dabce3).

Files with missing lines Patch % Lines
src/easyreflectometry/fitting.py 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           core_fixes     #388      +/-   ##
==============================================
- Coverage       31.66%   31.61%   -0.05%     
==============================================
  Files              48       48              
  Lines            3840     3846       +6     
==============================================
  Hits             1216     1216              
- Misses           2624     2630       +6     
Flag Coverage Δ
integration 31.61% <0.00%> (-0.05%) ⬇️
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyreflectometry/fitting.py 16.88% <0.00%> (-0.46%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rozyczko
rozyczko merged commit 8c765cd into core_fixes Jul 30, 2026
50 of 58 checks passed
@rozyczko
rozyczko deleted the core_fixes_lsq_test branch July 30, 2026 12:33
rozyczko added a commit that referenced this pull request Jul 30, 2026
* moved to Sampler class from Core

* reparent branch

* fixed issue #367 (#382)

* fixed issue #367

* disable automatic parallelization for windows

* Changes after code review

* added test

* arviz fix

* try to fix prettier issues

* updated notebook

* linting

* fixing #370 (#388)

* reparent to develop

* Core fixes pointwise (#387)

* fixed pointwise treatment on file load

* more tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fix to known bug [priority] high Should be prioritized soon [scope] bug Bug report or fix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant