Add standaloneLine set and Symfony attribute param fixer#56
Merged
Conversation
Add a fixer that breaks each argument of a Symfony attribute onto its own line, and a new opt-in "standaloneLine" set grouping the standalone-line constructor, promoted property, required param and attribute fixers. Move StandaloneLinePlainConstructorParamFixer out of the spaces set into the new standaloneLine set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standalone-line Symfony attribute fixer +
standaloneLinesetNew fixer:
StandaloneLineSymfonyAttributeParamFixerBreaks each argument of a Symfony attribute onto its own line (detection: the written attribute name contains the
Symfonynamespace part). Third-party attributes keep their layout.Skipped: attributes without arguments (
#[\Override]), empty argument lists, and non-Symfony attributes (e.g.#[\Doctrine\ORM\Mapping\Table(...)]).New
standaloneLinesetOpt-in set grouping the standalone-line rules:
StandaloneLineSymfonyAttributeParamFixer(new)StandaloneLinePromotedPropertyFixerStandaloneLinePlainConstructorParamFixerStandaloneLineRequiredParamFixerUsage:
Wired via
SetList::STANDALONE_LINEand a newwithPreparedSets(standaloneLine: ...)flag. Not part of thecommonaggregate — enable explicitly.Moved rule
StandaloneLinePlainConstructorParamFixerremoved from the spaces set (SpacesLevel::RULES); it now lives in the newstandaloneLineset.