Recognize imported short-name Symfony attributes#57
Merged
Conversation
…fonyAttributeParamFixer Resolve the attribute name via file use statements so short names like #[AsCommand(...)] imported from Symfony are handled, not only the fully-qualified #[\Symfony\...\AsCommand(...)] form.
TomasVotruba
enabled auto-merge (squash)
July 22, 2026 13:53
TomasVotruba
disabled auto-merge
July 22, 2026 13:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognize imported short-name Symfony attributes
Follow-up to #56.
StandaloneLineSymfonyAttributeParamFixerpreviously only matched attributes written with a fully-qualified name. It now also resolves short names against the file'susestatements, so imported Symfony attributes are handled too.Still matched: fully-qualified
#[\Symfony\...\AsCommand(...)].Still skipped: non-Symfony attributes, whether fully-qualified (
#[\Doctrine\ORM\Mapping\Table(...)]) or imported (use Doctrine\ORM\Mapping\Table; #[Table(...)]), argument-less attributes, and empty argument lists.How detection works
Symfony→ match (covers FQCN and partially-qualified).\) → skip.useimports; match when the resolved FQCN containsSymfony.