Skip to content

feat: Jetpack Compose Navigation support - #2136

Merged
romtsn merged 4 commits into
mainfrom
feat/compose-navigation-support
Jun 29, 2022
Merged

feat: Jetpack Compose Navigation support#2136
romtsn merged 4 commits into
mainfrom
feat/compose-navigation-support

Conversation

@romtsn

@romtsn romtsn commented Jun 24, 2022

Copy link
Copy Markdown
Member

📜 Description

Integration branch to track compose navigation support

💡 Motivation and Context

Closes #2096

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

* feat: Add compose module (navigation) (#2121)
* feat: Add compose sample (#2122)
@romtsn
romtsn requested a review from adinauer as a code owner June 24, 2022 11:08
@romtsn
romtsn marked this pull request as draft June 24, 2022 11:09
@github-actions

github-actions Bot commented Jun 24, 2022

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against bcc24c6

@adinauer adinauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed as separate PRs, so approving this as well

@philipphofmann philipphofmann left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's missing to finish this PR?

Comment thread sentry-android-navigation/build.gradle.kts
@romtsn

romtsn commented Jun 27, 2022

Copy link
Copy Markdown
Member Author

What's missing to finish this PR?

It's an integration branch for all other PRs (you already reviewed them separately) as mentioned in the description ;) This will have no unreviewed changes apart from a changelog entry when going into main

@romtsn
romtsn marked this pull request as ready for review June 29, 2022 11:39
@romtsn
romtsn merged commit 524ee49 into main Jun 29, 2022
@romtsn
romtsn deleted the feat/compose-navigation-support branch June 29, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Jetpack Compose Navigation support

3 participants