Skip to content

Add new modules to craft.yml - #2138

Merged
romtsn merged 1 commit into
feat/androidx-navigation-tracingfrom
feat/compose-and-navigation-craft
Jun 27, 2022
Merged

Add new modules to craft.yml#2138
romtsn merged 1 commit into
feat/androidx-navigation-tracingfrom
feat/compose-and-navigation-craft

Conversation

@romtsn

@romtsn romtsn commented Jun 24, 2022

Copy link
Copy Markdown
Member

#skip-changelog

@romtsn
romtsn requested a review from marandaneto as a code owner June 24, 2022 18:11
Comment thread .craft.yml
Comment on lines +44 to +45
maven:io.sentry:sentry-android-navigation:
maven:io.sentry:sentry-compose:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to add them first (manually) to https://github.com/getsentry/sentry-release-registry
otherwise, releases will fail.

@romtsn romtsn Jun 27, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we first push this to maven central and then merge the release registry? or it's the other way around?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, it's here getsentry/sentry-release-registry#76, and this PR goes into an integration branch, so I'm just gonna merge and wait before merging it into main if necessary

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the other way around, but if you merge this, you won't be able to release (push to maven central), because the release registry does not exist, craft will fail for non-preview releases.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks for explaining 👍 will make sure the release registry is out first

@romtsn
romtsn merged commit c5ceca7 into feat/androidx-navigation-tracing Jun 27, 2022
@romtsn
romtsn deleted the feat/compose-and-navigation-craft branch June 27, 2022 09:43
@romtsn romtsn mentioned this pull request Jun 27, 2022
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants