Skip to content

Add new modules to craft.yml #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romtsn merged 1 commit into from
Jun 27, 2022
Merged

Add new modules to craft.yml #2138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .craft.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,5 @@ targets:
maven:io.sentry:sentry-apollo:
maven:io.sentry:sentry-jdbc:
maven:io.sentry:sentry-graphql:
maven:io.sentry:sentry-android-navigation:
maven:io.sentry:sentry-compose:
Comment on lines +44 to +45

@marandaneto marandaneto Jun 25, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to add them first (manually) to https://github.com/getsentry/sentry-release-registry
otherwise, releases will fail.

@romtsn romtsn Jun 27, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we first push this to maven central and then merge the release registry? or it's the other way around?

@romtsn romtsn Jun 27, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, it's here getsentry/sentry-release-registry#76, and this PR goes into an integration branch, so I'm just gonna merge and wait before merging it into main if necessary

@marandaneto marandaneto Jun 27, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the other way around, but if you merge this, you won't be able to release (push to maven central), because the release registry does not exist, craft will fail for non-preview releases.

@romtsn romtsn Jun 27, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks for explaining 👍 will make sure the release registry is out first