Skip to content

.Net: Revert KernelAIFunction name separator using dash - #10827

Merged
rogerbarreto merged 5 commits into
microsoft:mainfrom
stephentoub:trytofix10819
Mar 18, 2025
Merged

.Net: Revert KernelAIFunction name separator using dash#10827
rogerbarreto merged 5 commits into
microsoft:mainfrom
stephentoub:trytofix10819

Conversation

@stephentoub

@stephentoub stephentoub commented Mar 6, 2025

Copy link
Copy Markdown
Member

Exploring fixing #10819. I'm interested in how CI reacts.

@rogerbarreto, any insights into why this previously changed from an underscore to a dash?

Thanks.

@stephentoub
stephentoub requested a review from a team as a code owner March 6, 2025 03:08
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels Mar 6, 2025
@github-actions github-actions Bot changed the title Revert KernelAIFunction name separator using dash .Net: Revert KernelAIFunction name separator using dash Mar 6, 2025
@rogerbarreto

Copy link
Copy Markdown
Member

This was made on this PR

Running my Demo with FunctionCAlling wasn't working using the _, SemanticKernel creates by default - dashes instead of underscores.

@stephentoub

Copy link
Copy Markdown
Member Author

What wasn't working / how wasn't it working?

@rogerbarreto rogerbarreto self-assigned this Mar 11, 2025
@rogerbarreto

Copy link
Copy Markdown
Member

I have tried again and could not reproduce the problem, if it arises again I will reach out.

@markwallace-microsoft
markwallace-microsoft added this pull request to the merge queue Mar 14, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 14, 2025
@rogerbarreto
rogerbarreto added this pull request to the merge queue Mar 14, 2025
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Mar 14, 2025
@rogerbarreto rogerbarreto added the PR: ready to merge PR has been approved by all reviewers, and is ready to merge. label Mar 15, 2025
@rogerbarreto
rogerbarreto enabled auto-merge March 18, 2025 10:12
@rogerbarreto
rogerbarreto added this pull request to the merge queue Mar 18, 2025
Merged via the queue into microsoft:main with commit c4de1ab Mar 18, 2025
jcruzmot-te pushed a commit to thousandeyes/aia-semantic-kernel that referenced this pull request Sep 15, 2025
)

Exploring fixing
microsoft#10819. I'm
interested in how CI reacts.

@rogerbarreto, any insights into why this previously changed from an
underscore to a dash?

Thanks.

Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Co-authored-by: Mark Wallace <127216156+markwallace-microsoft@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code PR: ready to merge PR has been approved by all reviewers, and is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.Net: Bug: Converting Kernel Plugins to AIFunctions fails name validation

4 participants