Skip to content

.Net: MS AI Ollama with Function calling - #9488

Merged
rogerbarreto merged 19 commits into
microsoft:mainfrom
rogerbarreto:issues/9275-ollama-msai-function-calling
Nov 8, 2024
Merged

.Net: MS AI Ollama with Function calling#9488
rogerbarreto merged 19 commits into
microsoft:mainfrom
rogerbarreto:issues/9275-ollama-msai-function-calling

Conversation

@rogerbarreto

@rogerbarreto rogerbarreto commented Oct 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Problem & Solution

This PR updates the Ollama Connector to use it's latest OllamaSharp updated version 4.0 where already supports the new Microsoft.Extensions.AI that can be completely leveraged by SK Abstractions including Function Calling support.

@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel kernel.core labels Oct 31, 2024
@rogerbarreto rogerbarreto self-assigned this Nov 1, 2024
stephentoub
stephentoub reviewed Nov 1, 2024
View reviewed changes
Comment thread dotnet/src/Connectors/Connectors.Ollama/Core/ServiceBase.cs Outdated
@rogerbarreto
rogerbarreto marked this pull request as ready for review November 7, 2024 12:11
@rogerbarreto
rogerbarreto requested a review from a team as a code owner November 7, 2024 12:11
@rogerbarreto rogerbarreto changed the title .Net: [WIP] MS AI Ollama with Function calling .Net: MS AI Ollama with Function calling Nov 7, 2024
@rogerbarreto rogerbarreto mentioned this pull request Nov 7, 2024
Closed
dmytrostruk
dmytrostruk approved these changes Nov 7, 2024
View reviewed changes
Comment thread dotnet/src/Connectors/Connectors.Ollama/Extensions/OllamaServiceCollectionExtensions.cs Outdated
Comment thread dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatCompletionServiceChatClient.cs
Comment thread dotnet/src/SemanticKernel.Abstractions/AI/ChatCompletion/ChatCompletionServiceChatClient.cs
Comment thread dotnet/src/SemanticKernel.Abstractions/AI/Embeddings/EmbeddingGenerationServiceExtensions.cs
ladeak
ladeak reviewed Nov 7, 2024
View reviewed changes
Comment thread dotnet/src/InternalUtilities/test/MultipleHttpMessageHandlerStub.cs Outdated
@rogerbarreto
rogerbarreto added this pull request to the merge queue Nov 8, 2024
Merged via the queue into microsoft:main with commit ca5e285 Nov 8, 2024
@rogerbarreto
rogerbarreto deleted the issues/9275-ollama-msai-function-calling branch November 8, 2024 12:27
@muqeet-khan muqeet-khan mentioned this pull request Nov 11, 2024
Closed
@rogerbarreto rogerbarreto mentioned this pull request Mar 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephentoub stephentoub stephentoub left review comments
@dmytrostruk dmytrostruk dmytrostruk approved these changes
@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes
+2 more reviewers
@ladeak ladeak ladeak left review comments
@RogerBarret0 RogerBarret0 RogerBarret0 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@rogerbarreto rogerbarreto

Labels

documentation kernel.core kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.Net: Ollama LocalModels FunctionCalling Support

7 participants

@rogerbarreto @stephentoub @ladeak @dmytrostruk @SergeyMenshykh @RogerBarret0 @markwallace-microsoft