Skip to content

.Net: Ollama Support Function Calling - #9275

Closed
rogerbarreto wants to merge 29 commits into
microsoft:mainfrom
rogerbarreto:issues/7442-ollama-function-calling
Closed

.Net: Ollama Support Function Calling#9275
rogerbarreto wants to merge 29 commits into
microsoft:mainfrom
rogerbarreto:issues/7442-ollama-function-calling

Conversation

@rogerbarreto

@rogerbarreto rogerbarreto commented Oct 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel labels Oct 15, 2024
@rogerbarreto
rogerbarreto marked this pull request as ready for review October 19, 2024 21:55
@rogerbarreto
rogerbarreto requested a review from a team as a code owner October 19, 2024 21:55
TaoChenOSU
TaoChenOSU reviewed Oct 24, 2024
View reviewed changes
Comment thread dotnet/src/Connectors/Connectors.Ollama/Services/OllamaChatCompletionService.cs Outdated
SergeyMenshykh
SergeyMenshykh approved these changes Oct 24, 2024
View reviewed changes
Comment thread dotnet/src/Connectors/Connectors.Ollama/Services/OllamaChatCompletionService.cs Outdated
@stephentoub

stephentoub commented Oct 30, 2024

Copy link
Copy Markdown
Member

Rather than merging new code for this support, now that OllamaSharp provides an IChatClient implementation, including function calling, should we start looking at this connector as the first to be on the new plan of just having the IChatCompletionService implementation use M.E.AI internally?

@rogerbarreto
rogerbarreto disabled auto-merge October 31, 2024 07:59
@rogerbarreto

rogerbarreto commented Oct 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

I have thought on that, with the recent merges now is possible to do as you saying. I will be updating this PR to use Ollama's sharp IChatClient internally with examples and a simple README.md, for community orientation

ladeak
ladeak reviewed Nov 3, 2024
View reviewed changes
Comment thread dotnet/src/Connectors/Connectors.Ollama/Services/OllamaTextGenerationService.cs
@rogerbarreto

rogerbarreto commented Nov 7, 2024

Copy link
Copy Markdown
Member Author

Closing this PR as it was superseded by

@rogerbarreto
rogerbarreto deleted the issues/7442-ollama-function-calling branch November 7, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TaoChenOSU TaoChenOSU TaoChenOSU left review comments
@SergeyMenshykh SergeyMenshykh SergeyMenshykh approved these changes
+2 more reviewers
@ladeak ladeak ladeak left review comments
@markwallace-microsoft markwallace-microsoft markwallace-microsoft approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@rogerbarreto rogerbarreto

Labels

kernel Issues or pull requests impacting the core kernel .NET Issue or Pull requests regarding .NET code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

.Net: Ollama LocalModels FunctionCalling Support

6 participants

@rogerbarreto @SergeyMenshykh @stephentoub @ladeak @TaoChenOSU @markwallace-microsoft