Skip to content

fix(NcAvatar): extend variable size of status icons - #5959

Merged
Antreesy merged 2 commits into
masterfrom
fix/noid/relative-user-status-size
Aug 14, 2024
Merged

fix(NcAvatar): extend variable size of status icons#5959
Antreesy merged 2 commits into
masterfrom
fix/noid/relative-user-status-size

Conversation

@Antreesy

@Antreesy Antreesy commented Aug 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

☑️ Resolves

  • Fix overlapping of status icons on small-sized avatars

🖼️ Screenshots

🏠 Before 🏡 After
image image

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@Antreesy
chore(docs): extend NcAvatar docs with different status icon and sizes
c679820 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy Antreesy added 3. to review Waiting for reviews design Design, UX, interface and interaction design feature: avatar Related to the avatar component labels Aug 14, 2024
@Antreesy Antreesy added this to the 8.16.1 milestone Aug 14, 2024
@Antreesy Antreesy self-assigned this Aug 14, 2024
@Antreesy
fix(NcAvatar): extend variable size for user statuses
69cc5dd 
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@Antreesy
Antreesy force-pushed the fix/noid/relative-user-status-size branch from bf8eee0 to 69cc5dd Compare August 14, 2024 09:59
@ShGKme ShGKme added the bug Something isn't working label Aug 14, 2024
ShGKme
ShGKme approved these changes Aug 14, 2024
View reviewed changes

@ShGKme ShGKme left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

marcoambrosini
marcoambrosini approved these changes Aug 14, 2024
View reviewed changes

@marcoambrosini marcoambrosini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Antreesy
Antreesy merged commit e8ce5f4 into master Aug 14, 2024
@Antreesy
Antreesy deleted the fix/noid/relative-user-status-size branch August 14, 2024 11:16
@Antreesy

Antreesy commented Aug 14, 2024

Copy link
Copy Markdown
Contributor Author

/backport to next

@backportbot backportbot Bot mentioned this pull request Aug 14, 2024
Merged
@Antreesy Antreesy mentioned this pull request Aug 15, 2024
Merged
5 tasks
@susnux susnux mentioned this pull request Aug 20, 2024
Merged
@susnux susnux modified the milestones: 8.16.1, 8.17.0 Aug 20, 2024
@ShGKme ShGKme mentioned this pull request Aug 22, 2024
Merged
3 tasks
@Stanislav1975 Stanislav1975 mentioned this pull request Sep 11, 2024
Open
@Antreesy Antreesy mentioned this pull request Sep 16, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShGKme ShGKme ShGKme approved these changes
@marcoambrosini marcoambrosini marcoambrosini approved these changes
@susnux susnux Awaiting requested review from susnux

Assignees

@Antreesy Antreesy

Labels

3. to review Waiting for reviews bug Something isn't working design Design, UX, interface and interaction design feature: avatar Related to the avatar component

Projects

None yet

Milestone

8.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@Antreesy @ShGKme @marcoambrosini @susnux