fix(NcAvatar): orbital best-fit adaptive status icon - #6004
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
ShGKme
force-pushed
the
fix/nc-avatar--scaling
branch
from
August 4, 2025 22:03
8cf3490 to
c2ba0b8
Compare
ShGKme
marked this pull request as ready for review
August 4, 2025 22:05
ShGKme
commented
Aug 4, 2025
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/nc-avatar--scaling
branch
from
August 5, 2025 08:46
c2ba0b8 to
4526cf5
Compare
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
ShGKme
force-pushed
the
fix/nc-avatar--scaling
branch
from
August 5, 2025 08:50
4526cf5 to
be27be4
Compare
susnux
approved these changes
Aug 5, 2025
DorraJaouad
approved these changes
Aug 5, 2025
DorraJaouad
left a comment
Contributor
There was a problem hiding this comment.
I love it 🦅
I had same issue when setting conversation icon in sidebar call, this was my approach with proportions
nextcloud/spreed@332cd35#diff-c9b05a3b55c5db03cb3bfb8c9ca12d8d9380405b7b405e870dfb2ce735c528b3
(it wasn't 100% accurate outside a certain interval)
It would be nice to implement orbital approach for future cases in Talk 👍🏻
This comment was marked as duplicate.
This comment was marked as duplicate.
Contributor
|
/backport to stable8 |
Merged
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves
Status icon size
This PR makes the status icon:
Edge case: small avatar
The solution above doesn't work well on a very small avatar. It makes the
--clickable-area-smallavatar🖼️ Screenshots
🏁 Checklist
nextrequested with a Vue 3 upgrade