fix webgpu changes - #6602
Closed
williamhCode wants to merge 1 commit into
Closed
Conversation
ocornut
pushed a commit
that referenced
this pull request
Jul 13, 2023
Owner
ocornut
added a commit
that referenced
this pull request
Jul 13, 2023
Change for #6602 broke, supposedly because using old version of emsdk. Initial reason for locking 3.1.37 was 3.1.38 had a bug, now fixed emscripten-core/emscripten#19363
ocornut
pushed a commit
that referenced
this pull request
Sep 16, 2024
Owner
|
Note that as of 1ac162f we have added define to facilitate supporting both Dawn and WGPU. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, Dawn had
.sourceinstead of.code, and didn't distinguish betweenWGPUFilterModeandWGPUMipmapFilterModebut it seems like Dawn is updated with thewebgpu.hheader now. With this change both wgpu-native and Dawn should work.