[PoC] Adapt example_glfw_wgpu to wgpu-native - #7523
Closed
eliemichel wants to merge 2 commits into
Closed
Conversation
Owner
|
Note that as of 1ac162f we have added define to facilitate supporting both Dawn and WGPU in the backends. |
Contributor
Author
|
Will do! Thanks for adding these defines. |
Contributor
Author
|
I haven't forgotten this, only wgpu-native and Dawn have been particularly desynchronized lately; working upstream on bringing missing bits to uniformization. |
Owner
|
This should be all solved by #8381 now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: This PoC comes as a complement to a remark in #7435.
Problems:
example_glfw_wgpuis tied to Dawn implementation for multiple reasons (see this comment).This PR shows an alternative version of
example_glfw_wgputhat useswgpu-native, and which is in general closer to what an implem-agnostic version would look like. It uses precompiled binaries, which makes building the example for quick testing much faster than building Dawn.Receipe to make this implem-agnostic:
FetchWgpuNative.cmakeby e.g., thewebgpu.cmakefile from my WebGPU-distribution repo (I did not want to impose this by default since I'm clearly biased in favor of my tool here -- my ultimate goal is that one day this whole distribution thing will no longer be needed).WEBGPU_BACKEND_WGPUorWEBGPU_BACKEND_DAWNthemselves as well.Due to all these reason I suggest not to merge this right away, but keeping the PR as a reference may be useful for the very near future.