feat: ory network cta for oss only - #2634
Conversation
📝 WalkthroughWalkthrough
ChangesOryNetworkCta OSS gating and refactor
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/OryNetworkCta/ory-network-cta.tsx (1)
2-2: Replace@ts-expect-errorwith a typed static-asset module declaration.Line 2 uses a global TypeScript error suppression for PNG imports. Since the repo has no existing
*.pngmodule declaration and webpack handles static assets at build time, add a type declaration file to properly type static imports and remove the suppression. This improves type safety while documenting how the build system resolves these assets.Create a
.d.tsfile (e.g.,src/types/assets.d.ts) with:declare module "*.png" { const content: string; export default content; }Then remove the
@ts-expect-errorcomment from line 2.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/components/OryNetworkCta/ory-network-cta.tsx` at line 2, To fix the type safety issue in ory-network-cta.tsx, create a new `.d.ts` file at `src/types/assets.d.ts` that declares the module type for PNG imports, specifying that PNG files resolve to string content at build time. Then remove the `@ts-expect-error` comment from line 2 in the ory-network-cta.tsx file so that TypeScript will use the proper module declaration instead of suppressing the error.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/components/OryNetworkCta/ory-network-cta.tsx`:
- Line 2: To fix the type safety issue in ory-network-cta.tsx, create a new
`.d.ts` file at `src/types/assets.d.ts` that declares the module type for PNG
imports, specifying that PNG files resolve to string content at build time. Then
remove the `@ts-expect-error` comment from line 2 in the ory-network-cta.tsx
file so that TypeScript will use the proper module declaration instead of
suppressing the error.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 1fcf8884-abdb-46b6-844d-d3e5cd4e4f4a
📒 Files selected for processing (1)
src/components/OryNetworkCta/ory-network-cta.tsx
* feat: Ory Network CTA for OSS deployment only * refactor: simplify image source handling in OryNetworkCta component
* docs: set redirects to premanent = true * docs: split /keto/docs/(|v0.5/):engine redirect into 2 redirects * feat: ory network cta for oss only (#2634) * feat: Ory Network CTA for OSS deployment only * refactor: simplify image source handling in OryNetworkCta component * docs: bump to 79e05a2469a39381d507936e72baed37b8300afc * docs: bump to 79e05a2469a39381d507936e72baed37b8300afc * feat: improve actions ux docs (#2615) * feat: improve actions ux docs * feat: apply suggestion remove bold * feat: apply suggestion on for one * docs: move talos redirects to vercel file * docs: ran make format * docs: changed to true * chore(docs): update of OEL images (#2637) * docs: deviceauthn relaxed attestation (#2630) --------- Co-authored-by: Wassim Bougarfa <12980387+wassimoo@users.noreply.github.com> Co-authored-by: aeneasr <3372410+aeneasr@users.noreply.github.com> Co-authored-by: Michelle Sagnelli <ing.sagnelli@gmail.com> Co-authored-by: ory-bot <60093411+ory-bot@users.noreply.github.com> Co-authored-by: Pierre Caillaud <93587351+pcaillaudm@users.noreply.github.com>
* docs: set redirects to premanent = true * docs: split /keto/docs/(|v0.5/):engine redirect into 2 redirects * feat: ory network cta for oss only (#2634) * feat: Ory Network CTA for OSS deployment only * refactor: simplify image source handling in OryNetworkCta component * docs: bump to 79e05a2469a39381d507936e72baed37b8300afc * docs: bump to 79e05a2469a39381d507936e72baed37b8300afc * feat: improve actions ux docs (#2615) * feat: improve actions ux docs * feat: apply suggestion remove bold * feat: apply suggestion on for one * docs: move talos redirects to vercel file * docs: ran make format * docs: changed to true * chore(docs): update of OEL images (#2637) * docs: deviceauthn relaxed attestation (#2630) --------- Co-authored-by: Wassim Bougarfa <12980387+wassimoo@users.noreply.github.com> Co-authored-by: aeneasr <3372410+aeneasr@users.noreply.github.com> Co-authored-by: Michelle Sagnelli <ing.sagnelli@gmail.com> Co-authored-by: ory-bot <60093411+ory-bot@users.noreply.github.com> Co-authored-by: Pierre Caillaud <93587351+pcaillaudm@users.noreply.github.com>
* docs: rewrites to intro to standardize * autogen(docs): generate cli docs * docs: bump to 79e05a2469a39381d507936e72baed37b8300afc * chore: update v2 thresholds (#2638) chore(rate-limits): update thresholds for v2 base-limit changes Sync the rate-limit CSVs from cloud (ory-corp/cloud) and regenerate rate-limits.json: HydraPublicHigh/KratosAdminHigh increases plus the 50->60 / 900->950 / 800->850 ratchets. * docs: bump to 9073260639be9811f21421e46d20948cb5a2952f * docs: set redirects to premanent = true (#2635) * docs: set redirects to premanent = true * docs: split /keto/docs/(|v0.5/):engine redirect into 2 redirects * feat: ory network cta for oss only (#2634) * feat: Ory Network CTA for OSS deployment only * refactor: simplify image source handling in OryNetworkCta component * docs: bump to 79e05a2469a39381d507936e72baed37b8300afc * docs: bump to 79e05a2469a39381d507936e72baed37b8300afc * feat: improve actions ux docs (#2615) * feat: improve actions ux docs * feat: apply suggestion remove bold * feat: apply suggestion on for one * docs: move talos redirects to vercel file * docs: ran make format * docs: changed to true * chore(docs): update of OEL images (#2637) * docs: deviceauthn relaxed attestation (#2630) --------- Co-authored-by: Wassim Bougarfa <12980387+wassimoo@users.noreply.github.com> Co-authored-by: aeneasr <3372410+aeneasr@users.noreply.github.com> Co-authored-by: Michelle Sagnelli <ing.sagnelli@gmail.com> Co-authored-by: ory-bot <60093411+ory-bot@users.noreply.github.com> Co-authored-by: Pierre Caillaud <93587351+pcaillaudm@users.noreply.github.com> * fix: update installation guides and sidebar paths (#2613) * fix: update installation guides and sidebar paths for kratos * fix: move kratos oss setup instruction path * fix: update installation paths to shared component for consistency * fix: reorganize keto installation docs * fix: formatting * fix: update installation and upgrade guides across deployment models * fix: format * fix: revert to master * fix: update installation link format in quickstart guide * fix: remove outdated redirect for keto quickstart guide * docs: remove old intro files * docs: added import files * Update docs/oel/getting-started/index.mdx Co-authored-by: Vincent <vincent@ory.sh> * docs: added review feedback --------- Co-authored-by: ory-bot <60093411+ory-bot@users.noreply.github.com> Co-authored-by: aeneasr <3372410+aeneasr@users.noreply.github.com> Co-authored-by: Andreas Bucksteeg <tricky42@users.noreply.github.com> Co-authored-by: Wassim Bougarfa <12980387+wassimoo@users.noreply.github.com> Co-authored-by: Michelle Sagnelli <ing.sagnelli@gmail.com> Co-authored-by: Pierre Caillaud <93587351+pcaillaudm@users.noreply.github.com> Co-authored-by: Vincent <vincent@ory.sh>
* docs: rewrites to intro to standardize * autogen(docs): generate cli docs * docs: bump to 79e05a2469a39381d507936e72baed37b8300afc * chore: update v2 thresholds (#2638) chore(rate-limits): update thresholds for v2 base-limit changes Sync the rate-limit CSVs from cloud (ory-corp/cloud) and regenerate rate-limits.json: HydraPublicHigh/KratosAdminHigh increases plus the 50->60 / 900->950 / 800->850 ratchets. * docs: bump to 9073260639be9811f21421e46d20948cb5a2952f * docs: set redirects to premanent = true (#2635) * docs: set redirects to premanent = true * docs: split /keto/docs/(|v0.5/):engine redirect into 2 redirects * feat: ory network cta for oss only (#2634) * feat: Ory Network CTA for OSS deployment only * refactor: simplify image source handling in OryNetworkCta component * docs: bump to 79e05a2469a39381d507936e72baed37b8300afc * docs: bump to 79e05a2469a39381d507936e72baed37b8300afc * feat: improve actions ux docs (#2615) * feat: improve actions ux docs * feat: apply suggestion remove bold * feat: apply suggestion on for one * docs: move talos redirects to vercel file * docs: ran make format * docs: changed to true * chore(docs): update of OEL images (#2637) * docs: deviceauthn relaxed attestation (#2630) --------- Co-authored-by: Wassim Bougarfa <12980387+wassimoo@users.noreply.github.com> Co-authored-by: aeneasr <3372410+aeneasr@users.noreply.github.com> Co-authored-by: Michelle Sagnelli <ing.sagnelli@gmail.com> Co-authored-by: ory-bot <60093411+ory-bot@users.noreply.github.com> Co-authored-by: Pierre Caillaud <93587351+pcaillaudm@users.noreply.github.com> * fix: update installation guides and sidebar paths (#2613) * fix: update installation guides and sidebar paths for kratos * fix: move kratos oss setup instruction path * fix: update installation paths to shared component for consistency * fix: reorganize keto installation docs * fix: formatting * fix: update installation and upgrade guides across deployment models * fix: format * fix: revert to master * fix: update installation link format in quickstart guide * fix: remove outdated redirect for keto quickstart guide * docs: remove old intro files * docs: added import files * Update docs/oel/getting-started/index.mdx Co-authored-by: Vincent <vincent@ory.sh> * docs: added review feedback --------- Co-authored-by: ory-bot <60093411+ory-bot@users.noreply.github.com> Co-authored-by: aeneasr <3372410+aeneasr@users.noreply.github.com> Co-authored-by: Andreas Bucksteeg <tricky42@users.noreply.github.com> Co-authored-by: Wassim Bougarfa <12980387+wassimoo@users.noreply.github.com> Co-authored-by: Michelle Sagnelli <ing.sagnelli@gmail.com> Co-authored-by: Pierre Caillaud <93587351+pcaillaudm@users.noreply.github.com> Co-authored-by: Vincent <vincent@ory.sh>
* docs: rewrites to intro to standardize * autogen(docs): generate cli docs * docs: bump to 79e05a2469a39381d507936e72baed37b8300afc * chore: update v2 thresholds (#2638) chore(rate-limits): update thresholds for v2 base-limit changes Sync the rate-limit CSVs from cloud (ory-corp/cloud) and regenerate rate-limits.json: HydraPublicHigh/KratosAdminHigh increases plus the 50->60 / 900->950 / 800->850 ratchets. * docs: bump to 9073260639be9811f21421e46d20948cb5a2952f * docs: set redirects to premanent = true (#2635) * docs: set redirects to premanent = true * docs: split /keto/docs/(|v0.5/):engine redirect into 2 redirects * feat: ory network cta for oss only (#2634) * feat: Ory Network CTA for OSS deployment only * refactor: simplify image source handling in OryNetworkCta component * docs: bump to 79e05a2469a39381d507936e72baed37b8300afc * docs: bump to 79e05a2469a39381d507936e72baed37b8300afc * feat: improve actions ux docs (#2615) * feat: improve actions ux docs * feat: apply suggestion remove bold * feat: apply suggestion on for one * docs: move talos redirects to vercel file * docs: ran make format * docs: changed to true * chore(docs): update of OEL images (#2637) * docs: deviceauthn relaxed attestation (#2630) --------- Co-authored-by: Wassim Bougarfa <12980387+wassimoo@users.noreply.github.com> Co-authored-by: aeneasr <3372410+aeneasr@users.noreply.github.com> Co-authored-by: Michelle Sagnelli <ing.sagnelli@gmail.com> Co-authored-by: ory-bot <60093411+ory-bot@users.noreply.github.com> Co-authored-by: Pierre Caillaud <93587351+pcaillaudm@users.noreply.github.com> * fix: update installation guides and sidebar paths (#2613) * fix: update installation guides and sidebar paths for kratos * fix: move kratos oss setup instruction path * fix: update installation paths to shared component for consistency * fix: reorganize keto installation docs * fix: formatting * fix: update installation and upgrade guides across deployment models * fix: format * fix: revert to master * fix: update installation link format in quickstart guide * fix: remove outdated redirect for keto quickstart guide * docs: remove old intro files * docs: added import files * Update docs/oel/getting-started/index.mdx Co-authored-by: Vincent <vincent@ory.sh> * docs: added review feedback --------- Co-authored-by: ory-bot <60093411+ory-bot@users.noreply.github.com> Co-authored-by: aeneasr <3372410+aeneasr@users.noreply.github.com> Co-authored-by: Andreas Bucksteeg <tricky42@users.noreply.github.com> Co-authored-by: Wassim Bougarfa <12980387+wassimoo@users.noreply.github.com> Co-authored-by: Michelle Sagnelli <ing.sagnelli@gmail.com> Co-authored-by: Pierre Caillaud <93587351+pcaillaudm@users.noreply.github.com> Co-authored-by: Vincent <vincent@ory.sh>
Checklist
If this pull request addresses a security vulnerability,
I confirm that I got approval (please contact security@ory.com) from the maintainers to push the changes.
Summary by CodeRabbit
Style
Refactor