fix: adapt screens to infinite edges feature by joragua · Pull Request #4887 · owncloud/android

joragua · 2026-06-11T10:36:27Z

Related Issues

App: #4576

Add changelog files for the fixed issues in folder changelog/unreleased. More info here
Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

#4887 (comment)

Reports:

(1) Passcode & Pattern views, not correct fix: adapt screens to infinite edges feature #4887 (comment) [FIXED]
(2) Receive external file fix: adapt screens to infinite edges feature #4887 (comment) [FIXED]
(3) Log files list fix: adapt screens to infinite edges feature #4887 (comment) [FIXED]
(4) File list in landscape weird effect fix: adapt screens to infinite edges feature #4887 (comment) [WONT FIX]
(5) Drawer scroll fix: adapt screens to infinite edges feature #4887 (comment) [FIXED]
(6) Toolbar missing in image preview fix: adapt screens to infinite edges feature #4887 (comment) [FIXED]
(7) Black background in operations menu fix: adapt screens to infinite edges feature #4887 (comment) [FIXED]
(8) Bottom bar of video/audio player fix: adapt screens to infinite edges feature #4887 (comment) [FIXED]
(9) Top bar does not reach the screen edges fix: adapt screens to infinite edges feature #4887 (comment) [PARTIALLY FIXED]

jesmrec

Just a couple of comments @joragua

jesmrec

CR Approved, moving to QA

jesmrec · 2026-06-16T08:08:30Z

QA checks

	Android 16	Android 15	Android 14	Reports
Settings	✅	✅	✅
Passcode	✅	✅	✅	FIXED: BUG
Pattern	✅	✅	✅	FIXED: BUG
Log Files	✅	✅	✅	FIXED: BUG
Auto Uploads	✅	✅	✅
Drawer	✅ ‼️	❌	✅	BUG Sometimes a black band in landscape
Top Bar	‼️	‼️	✅	PARTIALLY FIXED BUG
Bottom bar	✅	✅	✅	WONT FIX: BUG
Folder Picker	✅	✅	✅
Receive External file	✅	✅	✅	FIXED: BUG
Preview image	✅	✅	✅	FIXED: BUG
Preview video	✅	✅	✅	FIXED: BUG FIXED: BUG
Preview audio	✅	✅	✅	FIXED: BUG FIXED: BUG
Preview text	✅	✅	✅	FIXED: BUG
Share	✅	✅	✅
Spaces	✅	✅	✅
Uploads	✅	✅	✅
Priv. policy	✅	✅	✅
Release Notes	✅	✅	✅

jesmrec · 2026-06-16T08:29:25Z

(1) [FIXED]

About passcode & pattern views:

Top bar not visible (white)
Titles are closer to the top bar (in Android 16's Pattern are overlapped)
Also reproducible in landscape

Android 15	Android 16

Xiaomi Redmi Note 13, Android 15
Pixel 7, Android 16
6fcc322f

jesmrec · 2026-06-16T08:34:25Z

(2) [FIXED]

About the Receive External File view:

Xiaomi Redmi Note 13, Android 15
Pixel 7, Android 16
6fcc322f

jesmrec · 2026-06-16T08:40:28Z

(3) [FIXED]

Log file list

Xiaomi Redmi Note 13, Android 15
Pixel 7, Android 16
6fcc322f

jesmrec · 2026-06-16T09:01:34Z

(4) [WONT FIX]

Check this difference when the device has control buttons in landscape. Not very important, but, everything could be improved:

Current	v4.7.0

Xiaomi Redmi Note 13, Android 15
6fcc322f

jesmrec · 2026-06-16T09:55:32Z

(5) [FIXED]

About the drawer in landscape orientation:

Before: list of menu options and quota were scrolled at the time
Now: list of menu options and quota can collide during scroll:

Current	v4.7.0
https://github.com/user-attachments/assets/66098cac-22ec-4d69-90e2-5d8f4bbf1b9e	https://github.com/user-attachments/assets/41e054df-944e-485e-b086-5d1bb6de7b88

Xiaomi Redmi Note 13, Android 15
6fcc322f

Signed-off-by: Jorge Aguado Recio <jorgeagurec@gmail.com>

joragua · 2026-06-16T11:30:42Z

(1), (2) and (3) should be fixed now

Regarding the passcode and pattern screens, I’ve added the toolbar to the XML and used the adaptInfiniteEdges() extension. The others screens were easier -> use the extension

jesmrec · 2026-06-16T11:50:53Z

(1), (2) and (3) fixed

jesmrec · 2026-06-16T12:26:37Z

(6) [FIXED]

In Android 15 or 16, preview an image or a video

Current: Toolbar is not visible
Expected:: Toolbar visible

Current	v4.7.0

Xiaomi Redmi Note 13, Android 15
Pixel 7, Android 16
cd96a1e33

jesmrec · 2026-06-16T12:28:25Z

(7) [FIXED]

The multiselection operations menu's background in now black instead of white.

Xiaomi Redmi Note 13, Android 15
Pixel 7, Android 16
cd96a1e33

jesmrec · 2026-06-16T12:33:19Z

(8) [FIXED]

In the video/audio player, the bottom bar collides with the control buttons

Xiaomi Redmi Note 13, Android 15
cd96a1e33

Signed-off-by: Jorge Aguado Recio <jorgeagurec@gmail.com>

joragua · 2026-06-16T13:53:20Z

(6) and (7) should be fixed in commit 353237f -> Removed theme in PasscodeActivity and PatternActivity from manifest and restore the theme in the default action bar

(8) should be fixed in commit 8dfe9e7 -> Adapt content to infinite edges feature (the same as the other screens)

jesmrec · 2026-06-16T15:03:18Z

(6), (7) and (8) fixed

jesmrec · 2026-06-16T15:27:37Z

(9) [PARTIALLY FIXED]

Setting the mobile in landscape and enabling multiselection mode, top bar looks like:

It does not reach the screen edges and shows the stuff behind

Xiaomi Redmi Note 13, Android 15
Pixel 7, Android 16
8dfe9e720

joragua · 2026-06-16T16:09:52Z

Regarding (4): the sort menu is inside the fragment content, so it cannot be adapted to the edge-to-edge in a different way. It may look there is a strange white rectangle, but that's because the sort menu has the same color as the toolbar. There is one solution but it has an issue: the app buttons cannot be clicked due to the navigation system bar, so I would not apply that fix. I'd mark the report as a wontfix, but I'll open a new issue and wait to see if someone has a different solution 🤔

Signed-off-by: Jorge Aguado Recio <jorgeagurec@gmail.com>

joragua · 2026-06-17T09:57:26Z

Regarding (9), I’ve hidden the toolbar when multi-selection mode is enabled in order to avoid showing the avatar and the hamburger menu in landscape (fixed in this commit: 68d9552 ). Anyway I'll create a new issue to try to avoid glitches with the edge-to-edge feature (only reproducible on smartphones in landscape mode) because probably it's necessary to create a new design for the action bar.

…d user quota Signed-off-by: Jorge Aguado Recio <jorgeagurec@gmail.com>

joragua · 2026-06-17T12:25:08Z

(5) should be fixed now in commit 66dcf89

Restored the drawer structure and applied insets to the first NavigationView in the layout

jesmrec · 2026-06-17T16:24:06Z

Approved from my side

Reports (4) and (9) will be addressed to separate issues because the fix will require deep changes that go over the scope of the current issue.

joragua self-assigned this Jun 11, 2026

joragua linked an issue Jun 11, 2026 that may be closed by this pull request

[BUG] Infinite edges (starting from Android 15) #4576

Closed

joragua force-pushed the fix/infinite_edges branch 5 times, most recently from e00f447 to e43a125 Compare June 15, 2026 11:56

joragua requested a review from jesmrec June 15, 2026 12:15

joragua marked this pull request as ready for review June 15, 2026 12:15

jesmrec requested changes Jun 16, 2026

View reviewed changes

Comment thread owncloudApp/src/main/java/com/owncloud/android/ui/activity/UploadListActivity.java

Comment thread owncloudApp/src/main/java/com/owncloud/android/extensions/ActivityExt.kt

joragua requested a review from jesmrec June 16, 2026 07:56

jesmrec approved these changes Jun 16, 2026

View reviewed changes

joragua added 3 commits June 16, 2026 13:25

fix: adapt screens to infinite edges feature

ba10a15

Signed-off-by: Jorge Aguado Recio <jorgeagurec@gmail.com>

fix: remove infinite edges restrictions for Android 15

d75859e

Signed-off-by: Jorge Aguado Recio <jorgeagurec@gmail.com>

chore: add calens file

cd96a1e

Signed-off-by: Jorge Aguado Recio <jorgeagurec@gmail.com>

joragua force-pushed the fix/infinite_edges branch from 6fcc322 to cd96a1e Compare June 16, 2026 11:26

joragua added 2 commits June 16, 2026 15:46

fix: restore action bar style on screens that use it by default

353237f

Signed-off-by: Jorge Aguado Recio <jorgeagurec@gmail.com>

fix: adapt preview screens to infinite edges feature

8dfe9e7

Signed-off-by: Jorge Aguado Recio <jorgeagurec@gmail.com>

joragua force-pushed the fix/infinite_edges branch from 29ba9ed to 8dfe9e7 Compare June 16, 2026 13:49

fix: hide toolbar in multi-selection mode

68d9552

Signed-off-by: Jorge Aguado Recio <jorgeagurec@gmail.com>

fix: restore drawer structure to prevent collapse between sections an…

66dcf89

…d user quota Signed-off-by: Jorge Aguado Recio <jorgeagurec@gmail.com>

joragua force-pushed the fix/infinite_edges branch from 66bebfa to 66dcf89 Compare June 17, 2026 12:24

joragua mentioned this pull request Jun 17, 2026

[BUG] Multi-selection top bar not adapted to edge-to-edge in landscape #4892

Open

jesmrec added the Approved by qa label Jun 17, 2026

joragua merged commit 13ae7c8 into master Jun 17, 2026
10 of 11 checks passed

joragua deleted the fix/infinite_edges branch June 17, 2026 16:27

This was referenced Jun 18, 2026

[BUG] Navigation bar overlaps system bar #4889

Closed

[BUG] Sort menu not adapted to edge-to-edge in landscape #4898

Open

DeepDiver1975 mentioned this pull request Jun 26, 2026

[RELEASE] 4.8.2 #4903

Merged

6 tasks

Uh oh!

Conversation

joragua commented Jun 11, 2026 • edited by jesmrec Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related Issues

QA

Uh oh!

jesmrec left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jesmrec left a comment

Choose a reason for hiding this comment

Uh oh!

jesmrec commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

QA checks

Uh oh!

jesmrec commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(1) [FIXED]

Uh oh!

jesmrec commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(2) [FIXED]

Uh oh!

jesmrec commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(3) [FIXED]

Uh oh!

jesmrec commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(4) [WONT FIX]

Uh oh!

jesmrec commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(5) [FIXED]

Uh oh!

joragua commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jesmrec commented Jun 16, 2026

Uh oh!

jesmrec commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(6) [FIXED]

Uh oh!

jesmrec commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(7) [FIXED]

Uh oh!

jesmrec commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(8) [FIXED]

Uh oh!

joragua commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jesmrec commented Jun 16, 2026

Uh oh!

jesmrec commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

(9) [PARTIALLY FIXED]

Uh oh!

joragua commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joragua commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joragua commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jesmrec commented Jun 17, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

joragua commented Jun 11, 2026 •

edited by jesmrec

Loading

jesmrec commented Jun 16, 2026 •

edited

Loading

jesmrec commented Jun 16, 2026 •

edited

Loading

jesmrec commented Jun 16, 2026 •

edited

Loading

jesmrec commented Jun 16, 2026 •

edited

Loading

jesmrec commented Jun 16, 2026 •

edited

Loading

jesmrec commented Jun 16, 2026 •

edited

Loading

joragua commented Jun 16, 2026 •

edited

Loading

jesmrec commented Jun 16, 2026 •

edited

Loading

jesmrec commented Jun 16, 2026 •

edited

Loading

jesmrec commented Jun 16, 2026 •

edited

Loading

joragua commented Jun 16, 2026 •

edited

Loading

jesmrec commented Jun 16, 2026 •

edited

Loading

joragua commented Jun 16, 2026 •

edited

Loading

joragua commented Jun 17, 2026 •

edited

Loading

joragua commented Jun 17, 2026 •

edited

Loading